Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rector changes annotations, however shouldn't #5392

Closed
popovserhii opened this issue Jan 31, 2021 · 5 comments
Closed

Rector changes annotations, however shouldn't #5392

popovserhii opened this issue Jan 31, 2021 · 5 comments
Labels

Comments

@popovserhii
Copy link

Bug Report

Subject Details
Rector version dev-master@a4f0c01
Installed as composer dependency

Minimal PHP Code Causing Issue

https://getrector.org/demo/86d6de76-cfb2-4f81-bcc4-229617dc892a

Expected Behaviour

Rector shouldn't change annotations at all.

@TomasVotruba
Copy link
Member

Related to #4334

@TomasVotruba
Copy link
Member

The removed parameters are actually unused, so is removed related @param docs.
Could you clarify exactly where is the issue?

@popovserhii
Copy link
Author

@TomasVotruba
Take a note at defaults={"_is_public" = true} in @Route, after rules were applied there are no quotes anymore. This throws an error in Symfony.

before
defaults={"_is_public" = true}

after
defaults={_is_public=true}

@TomasVotruba
Copy link
Member

TomasVotruba commented Feb 8, 2021

Ah, I understand it clearly now, thank you.
Then it's related to #4334

@samsonasik
Copy link
Member

it seems already fixed ref https://getrector.org/demo/4f6ef7a8-5a7d-4f80-955c-74b30a5bb988 . I am closing it.

TomasVotruba added a commit that referenced this issue Dec 25, 2023
TomasVotruba added a commit that referenced this issue Dec 25, 2023
TomasVotruba added a commit that referenced this issue Dec 26, 2023
TomasVotruba added a commit that referenced this issue Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants