Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.0] Undocumented BC breaks #4765

Closed
TomasVotruba opened this issue Dec 3, 2020 · 2 comments
Closed

[PHP 8.0] Undocumented BC breaks #4765

TomasVotruba opened this issue Dec 3, 2020 · 2 comments
Labels
feature

Comments

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 3, 2020 •
edited
Loading

These should be part of PHP 8 set

See 82e92c0

  • private and final cannot be used together on class method
    → drop final, as private is stating it clearly for both

  • parent cannot be called, if no parent class
    → remove parent (handled by code quality rule)

  • __setState() must be static
    → add visibility to it
This was referenced Dec 5, 2020
Merged
Merged
Merged
@simivar
Copy link
Contributor

simivar commented Dec 5, 2020

Closing as it was done in #4792, #4794 and #4795.

@simivar simivar closed this as completed Dec 5, 2020
@TomasVotruba
Copy link
Member Author

Thank you 👍

TomasVotruba added a commit that referenced this issue Aug 11, 2023
@TomasVotruba
Updated Rector to commit dc6e83c69ff9848d5bbfeedc9c596a042239a840
9d88bf8 
rectorphp/rector-src@dc6e83c [e2e] Handle $rectorConfig->paths() with wilcards * config (#4765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simivar @TomasVotruba