Rector prefixed 0.8.56: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found #4736

simivar · 2020-11-30T09:35:27Z

Bug Report

Subject	Details
Rector version	0.8.56
Installed as	prefixed Rector PHAR

While trying to run a Rector with vendor/bin/rector there's an error happening:

❯ vendor/bin/rector
PHP Fatal error:  Uncaught Error: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found in /Users/[...]/vendor/rector/rector-prefixed/bin/rector:39
Stack trace:
#0 {main}
  thrown in /Users/[...]/vendor/rector/rector-prefixed/bin/rector on line 39
Fatal error: Uncaught Error: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found in /Users/[...]/vendor/rector/rector-prefixed/bin/rector:39
Stack trace:
#0 {main}
  thrown in /Users/[...]vendor/rector/rector-prefixed/bin/rector on line 39

Minimal PHP Code Causing Issue

Expected Behaviour

Rector running properly.

The text was updated successfully, but these errors were encountered:

simivar · 2020-11-30T09:36:53Z

I've seen @michaljusiega comment in #4606 but I feel like this is a separate issue not related to PHPStan. I came across that comment by luck and feel that a separate ticket will be easier to find and track for others so they know when it's fixed.

michaljusiega · 2020-11-30T09:38:35Z

No, is not related to PHPStan issue.

staabm · 2020-11-30T17:06:48Z

duplicates #4725

simivar · 2020-11-30T17:55:00Z

It doesn't duplicates #4725 as I have it installed as a normal Composer dependency, not a global one.

staabm · 2020-11-30T18:42:57Z

Sorry „duplicates“ was the wrong wording. It seems to be the same error though :)

bbouabou · 2020-12-07T18:02:08Z

Hello,

Did there is any workaround to use rector to upgrade a symfony 2.8 project ?

simivar · 2020-12-07T18:52:36Z

@TomasVotruba could you help us with this issue?

TomasVotruba · 2020-12-07T19:04:59Z

@simivar Basically, this PR needs to be finished: #4559
The fix is included there. I'm busy with other work, so no ETA on it. Any help is welcomed there.

arnaud-fr · 2020-12-08T07:30:32Z

Hello,

Did there is any workaround to use rector to upgrade a symfony 2.8 project ?

A suggested workaround : use the previous version 0.8.52 wich is based on a phar.

If you current environment contains version 0.8.56, first of all remove it :
composer remove rector/rector-prefixed.

Then install the previous version :
composer require rector/rector-prefixed 0.8.52

Note : the command init does not work in this version. You will have to copy the rector.php.dist by hand in your main directory.

TomasVotruba · 2020-12-27T10:46:21Z

Resolved by #4559

u01jmg3 · 2021-01-06T16:21:56Z

Still seeing this problem on 0.9.5

TomasVotruba · 2021-01-06T18:04:38Z

We'll need a reproducible repository to verify

Aerendir · 2021-01-11T14:07:41Z

@TomasVotruba , I have the same error, also if I use Bamarni composer bin plugin.

But my repo is public: https://github.com/Aerendir/component-array-writer

It is only one class, so is perfect for debugging...

I'm trying to solve the issue, but I have no idea where to start... Maybe you can having more experience with the issue that seems already happened...

To reproduce

Clone the repo locally
Switch to dev branch
Run vendor/bin/rector process --dry-run

Aerendir · 2021-01-11T14:28:21Z

Ok, the first problem seems to be in vendor/rector/rector/bin/rector.php:104

    /**
     * In case Rector is installed as vendor dependency,
     * this autoloads the project vendor/autoload.php, including Rector
     */
    public function autoloadProjectAutoloaderFile(): void
    {
        $this->loadIfExistsAndNotLoadedYet(__DIR__ . '/../../autoload.php');
+        $this->loadIfExistsAndNotLoadedYet(__DIR__ . '/../../../../vendor/autoload.php');
    }

As I'm using Bamarni Bin Composer plugin, the hard coded path is not correct as Rector is actually installed in vendor-bin/phpstan/vendor/rector/rector.

For this reason we need to go some levels up in the tree.

Adding the change proposed, the error changes to:

PHP Fatal error:  Uncaught TypeError: Symplify\PackageBuilder\Reflection\PrivatesCaller::callPrivateMethod(): Argument #3 ($arguments) must be of type array, Symfony\Component\Console\Input\ArgvInput given, called in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php on line 32 and defined in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php:20
Stack trace:
#0 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php(32): Symplify\PackageBuilder\Reflection\PrivatesCaller->callPrivateMethod(Object(Symfony\Component\Console\Application), 'configureIO', Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#1 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector.php(39): Rector\Core\Console\Style\SymfonyStyleFactory->create()
#2 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector(4): require_once('/Users/Aerendir...')
#3 {main}
  thrown in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php on line 20
Fatal error: Uncaught TypeError: Symplify\PackageBuilder\Reflection\PrivatesCaller::callPrivateMethod(): Argument #3 ($arguments) must be of type array, Symfony\Component\Console\Input\ArgvInput given, called in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php on line 32 and defined in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php:20
Stack trace:
#0 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php(32): Symplify\PackageBuilder\Reflection\PrivatesCaller->callPrivateMethod(Object(Symfony\Component\Console\Application), 'configureIO', Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#1 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector.php(39): Rector\Core\Console\Style\SymfonyStyleFactory->create()
#2 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector(4): require_once('/Users/Aerendir...')
#3 {main}
  thrown in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php on line 20

staabm · 2021-01-11T15:17:21Z

it seems the mentioned fix is the same as the one I suggested in #4726

Aerendir · 2021-01-11T17:40:50Z

@staabm , similar, not the same: your attempt was to support global install; mine supports installation through Bamarni Composer Bin, that is anyway at project level...

Aerendir · 2021-01-11T17:49:42Z

@TomasVotruba , the problem seems to be in Symplify.

I changed this:

    /**
     * @param object|string $object
     * @param mixed[] $arguments
     */
-    public function callPrivateMethod($object, string $methodName, array $arguments)
+    public function callPrivateMethod($object, string $methodName, $arguments)
    {
        $this->ensureIsNotNull($object, __METHOD__);

        if (is_string($object)) {
            $reflectionClass = new ReflectionClass($object);
            $object = $reflectionClass->newInstanceWithoutConstructor();
        }

        $methodReflection = $this->createAccessibleMethodReflection($object, $methodName);

+        if ($arguments instanceof ArgvInput) {
+            $arguments = $arguments->getArguments();
+        }

        return $methodReflection->invokeArgs($object, $arguments);
    }

But now I have other errors:

Aerendir@Archimede component-array-writer % vendor/bin/rector process --dry-run
PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Symfony\Component\Console\Application::configureIO(), 0 passed and exactly 2 expected in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symfony/console/Application.php:880
Stack trace:
#0 [internal function]: Symfony\Component\Console\Application->configureIO()
#1 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php(36): ReflectionMethod->invokeArgs(Object(Symfony\Component\Console\Application), Array)
#2 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php(32): Symplify\PackageBuilder\Reflection\PrivatesCaller->callPrivateMethod(Object(Symfony\Component\Console\Application), 'configureIO', Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector.php(39): Rector\Core\Console\Style\SymfonyStyleFactory->create()
#4 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector(4): require_once('/Users/Aerendir...')
#5 {main}
  thrown in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symfony/console/Application.php on line 880
Fatal error: Uncaught ArgumentCountError: Too few arguments to function Symfony\Component\Console\Application::configureIO(), 0 passed and exactly 2 expected in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symfony/console/Application.php:880
Stack trace:
#0 [internal function]: Symfony\Component\Console\Application->configureIO()
#1 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symplify/package-builder/src/Reflection/PrivatesCaller.php(36): ReflectionMethod->invokeArgs(Object(Symfony\Component\Console\Application), Array)
#2 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/src/Console/Style/SymfonyStyleFactory.php(32): Symplify\PackageBuilder\Reflection\PrivatesCaller->callPrivateMethod(Object(Symfony\Component\Console\Application), 'configureIO', Array, Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector.php(39): Rector\Core\Console\Style\SymfonyStyleFactory->create()
#4 /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/rector/rector/bin/rector(4): require_once('/Users/Aerendir...')
#5 {main}
  thrown in /Users/Aerendir/Documents/JooServer/Lab/Components/component-array-writer/vendor-bin/phpstan/vendor/symfony/console/Application.php on line 880

The problem seems to be deeper than what it appeared at a first sight.

See rectorphp/rector#4736 (comment)

TomasVotruba · 2021-01-11T18:15:47Z

Neither barmani or global installation is supported. If paths will be resolved, the different vendor directory name or double nesting or package conflicts will appear. We've experienced that in various private projects, before the prefixed Rector was available.

Now prefixed version is way to go here.

See rectorphp/rector#4736 (comment)

Aerendir · 2021-01-11T19:00:13Z

Ok, so Phive to the rescue!

Aerendir · 2021-01-11T19:01:13Z

Also if this makes really complex to stay up to date as Dependabot doesn't support Phive I think 🤔

TomasVotruba · 2021-01-11T19:12:56Z

Phive is packaged phar, that's what we droppped in 0.9 - Why? See https://getrector.org/blog/2020/12/28/rector-09-released#debuggable-rector-prefixed

This is prefixed Rector now: https://github.com/rectorphp/rector-prefixed

We go for the future of downgraded and prefixed version. Thank's to that Rector will be able to run on PHP 5.6 in composer and without Docker.

rectorphp/rector-src@ed7426f [Logging] Add RectorOutput logging service (#4736)

simivar added the bug label Nov 30, 2020

simivar added the prefixed label Nov 30, 2020

This was referenced Dec 3, 2020

Rector-Prefixed 0.8.50 not compatible with PHPStan PHAR #4606

Closed

"config/set/code-quality.php" was not found (and all others too) #4278

Closed

bbouabou mentioned this issue Dec 13, 2020

Upgrade a symfony 2.8 project #4873

Closed

TomasVotruba closed this as completed Dec 27, 2020

Aerendir mentioned this issue Jan 11, 2021

Reactivate Rector Aerendir/component-array-writer#171

Closed

Aerendir added a commit to Aerendir/component-array-writer that referenced this issue Jan 11, 2021

Temporarily disable Rector.

5a9c75a

See rectorphp/rector#4736 (comment)

Aerendir added a commit to Aerendir/component-array-writer that referenced this issue Jan 11, 2021

Temporarily disable Rector.

2e31bb9

See rectorphp/rector#4736 (comment)

TomasVotruba added a commit that referenced this issue Aug 9, 2023

Updated Rector to commit ed7426f02db446090399165a884ea7082e160d50

52d316d

rectorphp/rector-src@ed7426f [Logging] Add RectorOutput logging service (#4736)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rector prefixed 0.8.56: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found #4736

Rector prefixed 0.8.56: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found #4736

simivar commented Nov 30, 2020

simivar commented Nov 30, 2020 •

edited

Loading

michaljusiega commented Nov 30, 2020

staabm commented Nov 30, 2020

simivar commented Nov 30, 2020

staabm commented Nov 30, 2020

bbouabou commented Dec 7, 2020

simivar commented Dec 7, 2020

TomasVotruba commented Dec 7, 2020 •

edited

Loading

arnaud-fr commented Dec 8, 2020

TomasVotruba commented Dec 27, 2020

u01jmg3 commented Jan 6, 2021

TomasVotruba commented Jan 6, 2021

Aerendir commented Jan 11, 2021 •

edited

Loading

Aerendir commented Jan 11, 2021 •

edited

Loading

staabm commented Jan 11, 2021 •

edited

Loading

Aerendir commented Jan 11, 2021

Aerendir commented Jan 11, 2021

TomasVotruba commented Jan 11, 2021 •

edited

Loading

Aerendir commented Jan 11, 2021

Aerendir commented Jan 11, 2021 •

edited

Loading

TomasVotruba commented Jan 11, 2021 •

edited

Loading

Rector prefixed 0.8.56: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found #4736

Rector prefixed 0.8.56: Class 'Rector\Core\Console\Style\SymfonyStyleFactory' not found #4736

Comments

simivar commented Nov 30, 2020

Bug Report

Minimal PHP Code Causing Issue

Expected Behaviour

simivar commented Nov 30, 2020 • edited Loading

michaljusiega commented Nov 30, 2020

staabm commented Nov 30, 2020

simivar commented Nov 30, 2020

staabm commented Nov 30, 2020

bbouabou commented Dec 7, 2020

simivar commented Dec 7, 2020

TomasVotruba commented Dec 7, 2020 • edited Loading

arnaud-fr commented Dec 8, 2020

TomasVotruba commented Dec 27, 2020

u01jmg3 commented Jan 6, 2021

TomasVotruba commented Jan 6, 2021

Aerendir commented Jan 11, 2021 • edited Loading

To reproduce

Aerendir commented Jan 11, 2021 • edited Loading

staabm commented Jan 11, 2021 • edited Loading

Aerendir commented Jan 11, 2021

Aerendir commented Jan 11, 2021

TomasVotruba commented Jan 11, 2021 • edited Loading

Aerendir commented Jan 11, 2021

Aerendir commented Jan 11, 2021 • edited Loading

TomasVotruba commented Jan 11, 2021 • edited Loading

simivar commented Nov 30, 2020 •

edited

Loading

TomasVotruba commented Dec 7, 2020 •

edited

Loading

Aerendir commented Jan 11, 2021 •

edited

Loading

Aerendir commented Jan 11, 2021 •

edited

Loading

staabm commented Jan 11, 2021 •

edited

Loading

TomasVotruba commented Jan 11, 2021 •

edited

Loading

Aerendir commented Jan 11, 2021 •

edited

Loading

TomasVotruba commented Jan 11, 2021 •

edited

Loading