Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance #441

Closed
mssimi opened this issue Apr 28, 2018 · 5 comments
Closed

Performance #441

mssimi opened this issue Apr 28, 2018 · 5 comments

Comments

@mssimi
Copy link
Contributor

mssimi commented Apr 28, 2018 •
edited
Loading

I did some testing with blackfire.io you can check it here.

It seems like performance bottleneck comes from https://github.com/rectorphp/BetterReflection.

I did some testing and I think we may improve performance by adding caching here. I tested in on simple Symfony Form and I noticed it is actually doing same thing 3 times, if we cache it, we should improve performance by 300%.
@TomasVotruba
Copy link
Member

TomasVotruba commented Apr 28, 2018 •
edited
Loading

Why not send PR instead? :) It's very welcomed

@mssimi
Copy link
Contributor Author

mssimi commented Apr 28, 2018

May be BC break.

@TomasVotruba
Copy link
Member

So?

@carusogabriel
Copy link
Contributor

carusogabriel commented Apr 29, 2018 •
edited
Loading

May be BC break.

@mssimi Don't worry, Rector isn't even in Alpha, we can break whatever we want 😂

It seems like performance bottleneck comes from https://github.com/rectorphp/BetterReflection.

I'm tracking Roave/BetterReflection#410, because maybe the next version of BetterReflection can help us in performance as well.

@carusogabriel carusogabriel mentioned this issue May 13, 2018
Merged
3 tasks
@TomasVotruba
Copy link
Member

TomasVotruba commented May 30, 2018 •
edited
Loading

Closing for unclear intentions

TomasVotruba added a commit that referenced this issue Jul 16, 2021
@TomasVotruba
Updated Rector to commit b001e38
e71a1c1 
rectorphp/rector-src@b001e38 [TypeDeclaration] Skip ReturnTypeFromStrictTypedCallRector on possible no return (#441)
echo511 pushed a commit to echo511/rector that referenced this issue Sep 4, 2021
@samsonasik @actions-user
[TypeDeclaration] Skip ReturnTypeFromStrictTypedCallRector on possibl…
b001e38 
…e no return (rectorphp#441)

* [TypeDeclaration] Skip ReturnTypeFromStrictTypedCallRector on possible no return

* Fixed 🎉

* [ci-review] Rector Rectify

Co-authored-by: GitHub Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomasVotruba @mssimi @carusogabriel