Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Nette intro task for Eda #43

Closed
TomasVotruba opened this issue Sep 21, 2017 · 7 comments
Closed

Prepare Nette intro task for Eda #43

TomasVotruba opened this issue Sep 21, 2017 · 7 comments

Comments

@TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba
Copy link
Member Author

Hey @EdoBarnas, before we start, have you looked at some rector rules?
E.g. this one could be easy to understand https://github.com/RectorPHP/Rector/pull/66/files#diff-7c262fee93abbbb1dd81c32d77d886ad

@Tuzex
Copy link

Tuzex commented Oct 7, 2017

It looks good. I think, that understand it. Do I have to something focus on?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Oct 7, 2017

Great 👍

Do I have to something focus on?

Well, you could create first rector, to get the idea how this works. I think it would be useful, if it would solve some of your problems.

Do you have an idea of rector that would upgrade your code in Nette application?

@Tuzex
Copy link

Tuzex commented Oct 7, 2017

I will think on a moment

@Tuzex
Copy link

Tuzex commented Oct 7, 2017

Do you have any list with use cases? When i do mistake in english text, please corret me. Thanks. :)

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Oct 7, 2017

When i do mistake in english text, please corret me. Thanks. :)

Ok :) you can use "I" instead of "i". English with capital.


Do you have any list with use cases?

  1. This could be nice to start with:
    https://github.com/Kdyby/Doctrine/pull/298/files

I recall I had to do on many places manually.

  1. Or this one might be simpler:
    https://github.com/Kdyby/Validator/pull/24/files

@TomasVotruba
Copy link
Member Author

Ref #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants