--set mysql-to-mysqli seems to be executing the PHP code it should be analyzing

[phpfui]

Bug Report

Subject	Details
Rector version	v0.7.41
Installed as	composer dependency / php vendor\rector\rector\bin\rector

Running the mysql-to-mysqli set seems to run the code it is analyzing! It prints out things to the console (that the php should do if it were running) and will even stop execution of Rector with exit() (again, php would do this if the code were executed).

Minimal PHP Code Causing Issue

I am converting a large PHP 5.6 code base, so not sure exactly how to reproduce. Will update this if I can get something closer to a small example.

Expected Behaviour

Rector should not be executing code. It actually was finding unset array indices (which was good actually and I fixed). Very weird.

Running from Windows 10 with the following command:

php vendor\rector\rector\bin\rector process src\ajax --set mysql-to-mysqli --verbose

PHP is 7.4.7

I am more than happy to track this issue down and submit a PR, but not sure how to run Rector outside the phar file. Is there any documentation on debugging Rector?

Great tool by the way. Want to give back and make it even better!

[phpfui]

I have figured out how to debug Rector. Hope to have a PR at some point when I figure out the problem.

[phpfui]

So looks like the problem is the autoloader is including a file. But the file has plain PHP code in it as well as a class definition. So the include require does the standard PHP thing and executes the plain code. Will look into a work around on this, but real solution is to break the class out of the file.

[phpfui]

I was able to solve this easily by knowing what file was being include. It would generally fail as soon as the file was included. In case anyone else has this problem, the easiest solution is to print the file being required by RobotLoader\RobotLoader on line 114.

Ideally --verbose would output this information, but the problem is RobotLoader has no indication a file was loaded. Ideally RobotLoader::tryLoad would return the file it loaded or an empty string if it did not load a file. But RobotLoader is a separate project and the PR would get involved.

Closing this. Hope someone else can find this useful.

[TomasVotruba]

I wonder if this will get solved with static reflections. See #3490

[phpfui]

Not sure, basically you need to load a file. The would normally be a class and would not execute. But in my case (very old code with no autoloader and classes and raw php code mixed together), the require statement is causing PHP to read it in and execute it, since that is what PHP is supposed to do with a require statement.

If there is a commit I can test against, would be happy to so.

A solution may be to read the file by hand, then add it to the parser. I don't think there is a direct PHP to load but not execute a file. That would work as well.

[TomasVotruba]

That's exactly case for static reflection. To analyse even functions without loading them.

If there is a commit I can test against, would be happy to so.

There is just issue now 😅

Maybe other way around. If you can provide faling test case, I can create a fix for it.

[phpfui]

OK, I will come up with something. I think I understand the issue enough now.

…

On Thu, Jul 2, 2020 at 4:32 PM Tomas Votruba ***@***.***> wrote: That's exactly case for static reflection. To analyse even functions without loading them. If there is a commit I can test against, would be happy to so. There is just issue now 😅 Maybe other way around. If you can provide faling test case, I can create a fix for it. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3620 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYW6S34JYUOUMUCZ5PYMYTRZTVEZANCNFSM4OMPVZ7A> .

[phpfui]

Tomas,

I just ran my source through the latest Rector 0.7.46 and seems to have solved the problem. I also could not come up with a simple example, so I think we are done. I can reopen another issue with a small example if I run into it again.

[TomasVotruba]

Great. I'm glad it works.

Thanks for reaching out 👍