Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Reflection speed #273

Closed
TomasVotruba opened this issue Jan 6, 2018 · 4 comments
Closed

Improve Reflection speed #273

TomasVotruba opened this issue Jan 6, 2018 · 4 comments

Comments

@TomasVotruba
Copy link
Member

At the moment whole 3rd party code is parsed by php-parser via BetterReflection just to get class types.

The performance is very poor:

image

@carusogabriel
Copy link
Contributor

Any clue how to do that?

@TomasVotruba
Copy link
Member Author

I'd start with SmartClassReflector that handles reflection via BetterReflection

The BetterReflection now parses whole /vendor just to find out reflection for file. The order of SourceLocator should preffer autoloaded classes first.

But that's just one of my ideas, I believe you can find more places.

@TomasVotruba
Copy link
Member Author

Inspire for TypeResolving at Psalm

This could help with resolving type and performance issue we have with BetterReflection

@TomasVotruba
Copy link
Member Author

So far so good. It's be better to delegate on BetterReflection bump to php-parser 4: Roave/BetterReflection#410 and not reinvent the wheel

echo511 pushed a commit to echo511/rector that referenced this issue Sep 4, 2021
* cleanup bootstrpa config meta info, not useful

* misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants