Skip to content

Commit

Permalink
Updated Rector to commit 9b4ad93acd680c5da9a3bab4d5e1f46ad5905b7f
Browse files Browse the repository at this point in the history
rectorphp/rector-src@9b4ad93 Fix removal of useless @param tag when string|null insteadof ?string is used. (#5684)
  • Loading branch information
TomasVotruba committed Apr 3, 2024
1 parent bc02e10 commit 9f2e48f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
4 changes: 0 additions & 4 deletions rules/DeadCode/PhpDoc/TagRemover/ParamTagRemover.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ public function removeParamTagsIfUseless(PhpDocInfo $phpDocInfo, FunctionLike $f
if ($docNode->name !== '@param') {
return null;
}
// skip union types
if ($docNode->value->type instanceof UnionTypeNode) {
return null;
}
if (!$this->deadParamTagValueNodeAnalyzer->isDead($docNode->value, $functionLike)) {
return null;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Application/VersionResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = 'b925e54b913863053e57e628ea95b2fd612e128e';
public const PACKAGE_VERSION = '9b4ad93acd680c5da9a3bab4d5e1f46ad5905b7f';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2024-04-03 11:17:08';
public const RELEASE_DATE = '2024-04-03 11:59:45';
/**
* @var int
*/
Expand Down
2 changes: 1 addition & 1 deletion src/NodeTypeResolver/PHPStan/TypeHasher.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private function createUnionTypeHash(UnionType $unionType) : string
}
$normalizedUnionType = clone $unionType;
// change alias to non-alias
$normalizedUnionType = TypeTraverser::map($normalizedUnionType, static function (Type $type, callable $callable) : Type {
TypeTraverser::map($normalizedUnionType, static function (Type $type, callable $callable) : Type {
if (!$type instanceof AliasedObjectType && !$type instanceof ShortenedObjectType) {
return $callable($type);
}
Expand Down

0 comments on commit 9f2e48f

Please sign in to comment.