fixup! fixup! fixup! fixup! fixup! fixup! Add test case for #3222

rectorphp · May 4, 2020 · 4ebadc4 · 4ebadc4
1 parent acf4d1b
commit 4ebadc4
Showing 1 changed file with 21 additions and 15 deletions.
diff --git a/packages/better-php-doc-parser/src/PhpDocInfo/PhpDocInfoFactory.php b/packages/better-php-doc-parser/src/PhpDocInfo/PhpDocInfoFactory.php
@@ -22,6 +22,18 @@
 
 final class PhpDocInfoFactory
 {
+    // create empty node
+
+    /**
+     * @var string
+     */
+    private const CONTENT = '';
+
+    /**
+     * @var mixed[]
+     */
+    private const TOKENS = [];
+
     /**
      * @var PhpDocParser
      */
@@ -56,15 +68,6 @@ final class PhpDocInfoFactory
      * @var ParamPhpDocNodeFactory
      */
     private $paramPhpDocNodeFactory;
-    // create empty node
-    /**
-     * @var string
-     */
-    private const CONTENT = '';
-    /**
-     * @var mixed[]
-     */
-    private const TOKENS = [];
 
     public function __construct(
         PhpDocParser $phpDocParser,
@@ -91,12 +94,12 @@ public function createFromNode(Node $node): ?PhpDocInfo
 
         if ($node->getDocComment() === null) {
             return null;
-        } else {
-            $content = $node->getDocComment()->getText();
-            $tokens = $this->lexer->tokenize($content);
-            $phpDocNode = $this->parseTokensToPhpDocNode($tokens);
-            $this->setPositionOfLastToken($phpDocNode);
         }
+        $content = $node->getDocComment()->getText();
+        $tokens = $this->lexer->tokenize($content);
+        $phpDocNode = $this->parseTokensToPhpDocNode($tokens);
+        $this->setPositionOfLastToken($phpDocNode);
+
 
         return $this->createFromPhpDocNode($phpDocNode, $content, $tokens, $node);
     }
@@ -145,7 +148,10 @@ private function createFromPhpDocNode(
         Node $node
     ): PhpDocInfo {
         /** @var AttributeAwarePhpDocNode $phpDocNode */
-        $attributeAwarePhpDocNode = $this->attributeAwareNodeFactory->createFromNode($attributeAwarePhpDocNode, $content);
+        $attributeAwarePhpDocNode = $this->attributeAwareNodeFactory->createFromNode(
+            $attributeAwarePhpDocNode,
+            $content
+        );
 
         $phpDocInfo = new PhpDocInfo(
             $attributeAwarePhpDocNode,