-
-
Notifications
You must be signed in to change notification settings - Fork 699
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated Rector to commit 5ac3cb377abf968396c23573d8562e6ab6967f2a
rectorphp/rector-src@5ac3cb3 [Php70] Fix Php4 contructor not replaced with __construct() on php 7.4 environment (#5189)
- Loading branch information
1 parent
58494f4
commit 440cc19
Showing
7 changed files
with
141 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 131 additions & 0 deletions
131
...downgrade-php/rules/DowngradePhp81/Rector/FuncCall/DowngradeHashAlgorithmXxHashRector.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| <?php | ||
|
|
||
| declare (strict_types=1); | ||
| namespace Rector\DowngradePhp81\Rector\FuncCall; | ||
|
|
||
| use PhpParser\Node; | ||
| use PhpParser\Node\Arg; | ||
| use PhpParser\Node\Expr\ConstFetch; | ||
| use PhpParser\Node\Expr\FuncCall; | ||
| use PhpParser\Node\Scalar\String_; | ||
| use Rector\Core\NodeAnalyzer\ArgsAnalyzer; | ||
| use Rector\Core\PhpParser\Node\Value\ValueResolver; | ||
| use Rector\Core\Rector\AbstractRector; | ||
| use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; | ||
| use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | ||
| /** | ||
| * @see \Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\DowngradeHashAlgorithmXxHashRectorTest | ||
| */ | ||
| final class DowngradeHashAlgorithmXxHashRector extends AbstractRector | ||
| { | ||
| /** | ||
| * @readonly | ||
| * @var \Rector\Core\NodeAnalyzer\ArgsAnalyzer | ||
| */ | ||
| private $argsAnalyzer; | ||
| /** | ||
| * @readonly | ||
| * @var \Rector\Core\PhpParser\Node\Value\ValueResolver | ||
| */ | ||
| private $valueResolver; | ||
| private const HASH_ALGORITHMS_TO_DOWNGRADE = ['xxh32' => \MHASH_XXH32, 'xxh64' => \MHASH_XXH64, 'xxh3' => \MHASH_XXH3, 'xxh128' => \MHASH_XXH128]; | ||
| private const REPLACEMENT_ALGORITHM = 'md5'; | ||
| /** | ||
| * @var int | ||
| */ | ||
| private $argNamedKey; | ||
| public function __construct(ArgsAnalyzer $argsAnalyzer, ValueResolver $valueResolver) | ||
| { | ||
| $this->argsAnalyzer = $argsAnalyzer; | ||
| $this->valueResolver = $valueResolver; | ||
| } | ||
| public function getRuleDefinition() : RuleDefinition | ||
| { | ||
| return new RuleDefinition('Downgrade hash algorithm xxh32, xxh64, xxh3 or xxh128 by default to md5. You can configure the algorithm to downgrade.', [new CodeSample(<<<'CODE_SAMPLE' | ||
| class SomeClass | ||
| { | ||
| public function run() | ||
| { | ||
| return hash('xxh128', 'some-data-to-hash'); | ||
| } | ||
| } | ||
| CODE_SAMPLE | ||
| , <<<'CODE_SAMPLE' | ||
| class SomeClass | ||
| { | ||
| public function run() | ||
| { | ||
| return hash('md5', 'some-data-to-hash'); | ||
| } | ||
| } | ||
| CODE_SAMPLE | ||
| )]); | ||
| } | ||
| /** | ||
| * @return array<class-string<Node>> | ||
| */ | ||
| public function getNodeTypes() : array | ||
| { | ||
| return [FuncCall::class]; | ||
| } | ||
| /** | ||
| * @param FuncCall $node | ||
| */ | ||
| public function refactor(Node $node) : ?Node | ||
| { | ||
| if ($this->shouldSkip($node)) { | ||
| return null; | ||
| } | ||
| $this->argNamedKey = 0; | ||
| $algorithm = $this->getHashAlgorithm($node->getArgs()); | ||
| if ($algorithm === null || !\array_key_exists($algorithm, self::HASH_ALGORITHMS_TO_DOWNGRADE)) { | ||
| return null; | ||
| } | ||
| $args = $node->getArgs(); | ||
| if (!isset($args[$this->argNamedKey])) { | ||
| return null; | ||
| } | ||
| $arg = $args[$this->argNamedKey]; | ||
| $arg->value = new String_(self::REPLACEMENT_ALGORITHM); | ||
| return $node; | ||
| } | ||
| private function shouldSkip(FuncCall $funcCall) : bool | ||
| { | ||
| if ($funcCall->isFirstClassCallable()) { | ||
| return \true; | ||
| } | ||
| return !$this->nodeNameResolver->isName($funcCall, 'hash'); | ||
| } | ||
| /** | ||
| * @param Arg[] $args | ||
| */ | ||
| private function getHashAlgorithm(array $args) : ?string | ||
| { | ||
| $arg = null; | ||
| if ($this->argsAnalyzer->hasNamedArg($args)) { | ||
| foreach ($args as $key => $arg) { | ||
| if ((($nullsafeVariable1 = $arg->name) ? $nullsafeVariable1->name : null) !== 'algo') { | ||
| continue; | ||
| } | ||
| $this->argNamedKey = $key; | ||
| break; | ||
| } | ||
| } else { | ||
| $arg = $args[$this->argNamedKey]; | ||
| } | ||
| $algorithmNode = ($nullsafeVariable2 = $arg) ? $nullsafeVariable2->value : null; | ||
| switch (\true) { | ||
| case $algorithmNode instanceof String_: | ||
| return $this->valueResolver->getValue($algorithmNode); | ||
| case $algorithmNode instanceof ConstFetch: | ||
| return $this->mapConstantToString($this->valueResolver->getValue($algorithmNode)); | ||
| default: | ||
| return null; | ||
| } | ||
| } | ||
| private function mapConstantToString(string $constant) : string | ||
| { | ||
| $mappedConstant = \array_search(\constant($constant), self::HASH_ALGORITHMS_TO_DOWNGRADE, \true); | ||
| return $mappedConstant !== \false ? $mappedConstant : $constant; | ||
| } | ||
| } |