-
-
Notifications
You must be signed in to change notification settings - Fork 687
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated Rector to commit 093bcb63a19db3fcdab8264897c584212d755463
rectorphp/rector-src@093bcb6 [CodeQuality] Add NumberCompareToMaxFuncCallRector (#4914)
- Loading branch information
1 parent
f4213d1
commit 2ae279b
Showing
10 changed files
with
161 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
rules/CodeQuality/Rector/Ternary/NumberCompareToMaxFuncCallRector.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
<?php | ||
|
||
declare (strict_types=1); | ||
namespace Rector\CodeQuality\Rector\Ternary; | ||
|
||
use PhpParser\Node\Expr\BinaryOp\GreaterOrEqual; | ||
use PhpParser\Node; | ||
use PhpParser\Node\Expr\BinaryOp; | ||
use PhpParser\Node\Expr\BinaryOp\Greater; | ||
use PhpParser\Node\Expr\BinaryOp\Smaller; | ||
use PhpParser\Node\Expr\BinaryOp\SmallerOrEqual; | ||
use PhpParser\Node\Expr\Ternary; | ||
use Rector\Core\Rector\AbstractRector; | ||
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; | ||
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | ||
/** | ||
* @see \Rector\Tests\CodeQuality\Rector\Ternary\NumberCompareToMaxFuncCallRector\NumberCompareToMaxFuncCallRectorTest | ||
*/ | ||
final class NumberCompareToMaxFuncCallRector extends AbstractRector | ||
{ | ||
public function getRuleDefinition() : RuleDefinition | ||
{ | ||
return new RuleDefinition('Ternary number compare to max() call', [new CodeSample(<<<'CODE_SAMPLE' | ||
class SomeClass | ||
{ | ||
public function run($value) | ||
{ | ||
return $value > 100 ? $value : 100; | ||
} | ||
} | ||
CODE_SAMPLE | ||
, <<<'CODE_SAMPLE' | ||
class SomeClass | ||
{ | ||
public function run($value) | ||
{ | ||
return max($value, 100); | ||
} | ||
} | ||
CODE_SAMPLE | ||
)]); | ||
} | ||
/** | ||
* @return array<class-string<Node>> | ||
*/ | ||
public function getNodeTypes() : array | ||
{ | ||
return [Ternary::class]; | ||
} | ||
/** | ||
* @param Ternary $node | ||
*/ | ||
public function refactor(Node $node) : ?Node | ||
{ | ||
if (!$node->cond instanceof BinaryOp) { | ||
return null; | ||
} | ||
$binaryOp = $node->cond; | ||
if (!$this->areIntegersCompared($binaryOp)) { | ||
return null; | ||
} | ||
if ($binaryOp instanceof Smaller || $binaryOp instanceof SmallerOrEqual) { | ||
if (!$this->nodeComparator->areNodesEqual($binaryOp->left, $node->else)) { | ||
return null; | ||
} | ||
if (!$this->nodeComparator->areNodesEqual($binaryOp->right, $node->if)) { | ||
return null; | ||
} | ||
return $this->nodeFactory->createFuncCall('max', [$node->if, $node->else]); | ||
} | ||
if ($binaryOp instanceof Greater || $binaryOp instanceof GreaterOrEqual) { | ||
if (!$this->nodeComparator->areNodesEqual($binaryOp->left, $node->if)) { | ||
return null; | ||
} | ||
if (!$this->nodeComparator->areNodesEqual($binaryOp->right, $node->else)) { | ||
return null; | ||
} | ||
return $this->nodeFactory->createFuncCall('max', [$node->if, $node->else]); | ||
} | ||
return null; | ||
} | ||
private function areIntegersCompared(BinaryOp $binaryOp) : bool | ||
{ | ||
$leftType = $this->getType($binaryOp->left); | ||
if (!$leftType->isInteger()->yes()) { | ||
return \false; | ||
} | ||
$rightType = $this->getType($binaryOp->right); | ||
return $rightType->isInteger()->yes(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters