switch getRulesWithConfiguration() to config first approach

Abc\FqnizeNamespaced,

@@ -0,0 +1,3 @@
+PHPUnit 9.5.2 by Sebastian Bergmann and contributors.
+
+Cannot open file "FqnizeNamespaced".

composer.json

@@ -96,7 +96,7 @@
             "Rector\\CodeQuality\\": "rules/code-quality/src",
             "Rector\\CodingStyle\\": "rules/coding-style/src",
             "Rector\\Composer\\": "rules/composer/src",
-            "Rector\\Core\\": ["src", "rules/core/src"],
+            "Rector\\Core\\": "src",
             "Rector\\DeadCode\\": "rules/dead-code/src",
             "Rector\\DependencyInjection\\": "rules/dependency-injection/src",
             "Rector\\EarlyReturn\\": "rules/early-return/src",

config/set/downgrade-php71.php

@@ -27,6 +27,7 @@
 
     // skip classes used in PHP DocBlocks, like in /** @var \Some\Class */ [default: true]
     $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
     $services->set(DowngradeClassConstantVisibilityRector::class);
     $services->set(DowngradePipeToMultiCatchExceptionRector::class);
     $services->set(SymmetricArrayDestructuringToListRector::class);

config/set/downgrade-php72.php

@@ -22,5 +22,6 @@
 
     // skip classes used in PHP DocBlocks, like in /** @var \Some\Class */ [default: true]
     $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
     $services->set(DowngradeParameterTypeWideningRector::class);
 };

config/set/downgrade-php73.php

@@ -23,6 +23,7 @@
 
     // skip classes used in PHP DocBlocks, like in /** @var \Some\Class */ [default: true]
     $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
     $services->set(DowngradeTrailingCommasInFunctionCallsRector::class);
     $services->set(SetCookieOptionsArrayToArgumentsRector::class);
 };

config/set/downgrade-php74.php

@@ -37,6 +37,7 @@
 
     // skip classes used in PHP DocBlocks, like in /** @var \Some\Class */ [default: true]
     $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
     $services->set(DowngradeFreadFwriteFalsyToNegationRector::class);
     $services->set(DowngradeReturnSelfTypeDeclarationRector::class);
 };

config/set/downgrade-php80.php

@@ -35,6 +35,7 @@
 
     // skip classes used in PHP DocBlocks, like in /** @var \Some\Class */ [default: true]
     $parameters->set(Option::IMPORT_DOC_BLOCKS, false);
+
     $services->set(DowngradePropertyPromotionRector::class);
     $services->set(DowngradeNonCapturingCatchesRector::class);
     $services->set(DowngradeMatchToSwitchRector::class);

config/set/guzzle50.php

@@ -7,7 +7,7 @@
 use Rector\Renaming\ValueObject\MethodCallRename;
 use Rector\Transform\Rector\FuncCall\FuncCallToMethodCallRector;
 use Rector\Transform\Rector\StaticCall\StaticCallToFuncCallRector;
-use Rector\Transform\ValueObject\FuncNameToMethodCallName;
+use Rector\Transform\ValueObject\FuncCallToMethodCall;
 use Rector\Transform\ValueObject\StaticCallToFuncCall;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
@@ -19,8 +19,8 @@
     $services->set(FluentChainMethodCallToNormalMethodCallRector::class);
 
     $configuration = [
-        new FuncNameToMethodCallName('GuzzleHttp\json_decode', 'GuzzleHttp\Utils', 'jsonDecode'),
-        new FuncNameToMethodCallName('GuzzleHttp\get_path', 'GuzzleHttp\Utils', 'getPath'),
+        new FuncCallToMethodCall('GuzzleHttp\json_decode', 'GuzzleHttp\Utils', 'jsonDecode'),
+        new FuncCallToMethodCall('GuzzleHttp\get_path', 'GuzzleHttp\Utils', 'getPath'),
     ];
 
     $services->set(FuncCallToMethodCallRector::class)

docs/rector_rules_overview.md

@@ -9544,17 +9544,17 @@ Move array argument from tests into data provider [configurable]
 - class: `Rector\PHPUnit\Rector\Class_\ArrayArgumentInTestToDataProviderRector`
 
 ```php
-use Rector\PHPUnit\Rector\Class_\ArrayArgumentInTestToDataProviderRector;
+use Rector\PHPUnit\Rector\Class_\ArrayArgumentToDataProviderRector;
 use Rector\PHPUnit\ValueObject\ArrayArgumentToDataProvider;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
 
-    $services->set(ArrayArgumentInTestToDataProviderRector::class)
+    $services->set(ArrayArgumentToDataProviderRector::class)
         ->call('configure', [[
-            ArrayArgumentInTestToDataProviderRector::ARRAY_ARGUMENTS_TO_DATA_PROVIDERS => ValueObjectInliner::inline([
+            ArrayArgumentToDataProviderRector::ARRAY_ARGUMENTS_TO_DATA_PROVIDERS => ValueObjectInliner::inline([
                 new ArrayArgumentToDataProvider('PHPUnit\Framework\TestCase', 'doTestMultiple', 'doTestSingle', 'number'),
             ]),
         ]]);
@@ -13868,7 +13868,7 @@ In case you have accidentally removed use imports but code still contains partia
 
 ```php
 use Rector\Restoration\Rector\Namespace_\CompleteImportForPartialAnnotationRector;
-use Rector\Restoration\ValueObject\UseWithAlias;
+use Rector\Restoration\ValueObject\CompleteImportForPartialAnnotation;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -13878,7 +13878,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
     $services->set(CompleteImportForPartialAnnotationRector::class)
         ->call('configure', [[
             CompleteImportForPartialAnnotationRector::USE_IMPORTS_TO_RESTORE => ValueObjectInliner::inline([
-                new UseWithAlias('Doctrine\ORM\Mapping', 'ORM'),
+                new CompleteImportForPartialAnnotation('Doctrine\ORM\Mapping', 'ORM'),
             ]),
         ]]);
 };
@@ -15411,17 +15411,17 @@ Replaces constant by value
 - class: `Rector\Transform\Rector\ClassConstFetch\ClassConstFetchToStringRector`
 
 ```php
-use Rector\Transform\Rector\ClassConstFetch\ClassConstFetchToStringRector;
+use Rector\Transform\Rector\ClassConstFetch\ClassConstFetchToValueRector;
 use Rector\Transform\ValueObject\ClassConstFetchToValue;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
 return static function (ContainerConfigurator $containerConfigurator): void {
     $services = $containerConfigurator->services();
 
-    $services->set(ClassConstFetchToStringRector::class)
+    $services->set(ClassConstFetchToValueRector::class)
         ->call('configure', [[
-            ClassConstFetchToStringRector::CLASS_CONST_FETCHES_TO_VALUES => ValueObjectInliner::inline([
+            ClassConstFetchToValueRector::CLASS_CONST_FETCHES_TO_VALUES => ValueObjectInliner::inline([
                 new ClassConstFetchToValue('Nette\Configurator', 'DEVELOPMENT', 'development'),
                 new ClassConstFetchToValue('Nette\Configurator', 'PRODUCTION', 'production'),
             ]),
@@ -15493,7 +15493,7 @@ Turns defined function calls to local method calls.
 
 ```php
 use Rector\Transform\Rector\FuncCall\FuncCallToMethodCallRector;
-use Rector\Transform\ValueObject\FuncNameToMethodCallName;
+use Rector\Transform\ValueObject\FuncCallToMethodCall;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -15503,7 +15503,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
     $services->set(FuncCallToMethodCallRector::class)
         ->call('configure', [[
             FuncCallToMethodCallRector::FUNC_CALL_TO_CLASS_METHOD_CALL => ValueObjectInliner::inline([
-                new FuncNameToMethodCallName('view', 'Namespaced\SomeRenderer', 'render'),
+                new FuncCallToMethodCall('view', 'Namespaced\SomeRenderer', 'render'),
             ]),
         ]]);
 };
@@ -16488,7 +16488,7 @@ Turns defined `__isset`/`__unset` calls to specific method calls.
 
 ```php
 use Rector\Transform\Rector\Isset_\UnsetAndIssetToMethodCallRector;
-use Rector\Transform\ValueObject\IssetUnsetToMethodCall;
+use Rector\Transform\ValueObject\UnsetAndIssetToMethodCall;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -16498,7 +16498,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
     $services->set(UnsetAndIssetToMethodCallRector::class)
         ->call('configure', [[
             UnsetAndIssetToMethodCallRector::ISSET_UNSET_TO_METHOD_CALL => ValueObjectInliner::inline([
-                new IssetUnsetToMethodCall('SomeContainer', 'hasService', 'removeService'),
+                new UnsetAndIssetToMethodCall('SomeContainer', 'hasService', 'removeService'),
             ]),
         ]]);
 };
@@ -16516,7 +16516,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
 
 ```php
 use Rector\Transform\Rector\Isset_\UnsetAndIssetToMethodCallRector;
-use Rector\Transform\ValueObject\IssetUnsetToMethodCall;
+use Rector\Transform\ValueObject\UnsetAndIssetToMethodCall;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -16526,7 +16526,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
     $services->set(UnsetAndIssetToMethodCallRector::class)
         ->call('configure', [[
             UnsetAndIssetToMethodCallRector::ISSET_UNSET_TO_METHOD_CALL => ValueObjectInliner::inline([
-                new IssetUnsetToMethodCall('SomeContainer', 'hasService', 'removeService'),
+                new UnsetAndIssetToMethodCall('SomeContainer', 'hasService', 'removeService'),
             ]),
         ]]);
 };
@@ -16967,7 +16967,7 @@ Change visibility of constant from parent class.
 
 ```php
 use Rector\Visibility\Rector\ClassConst\ChangeConstantVisibilityRector;
-use Rector\Visibility\ValueObject\ClassConstantVisibilityChange;
+use Rector\Visibility\ValueObject\ChangeConstantVisibility;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symplify\SymfonyPhpConfig\ValueObjectInliner;
 
@@ -16977,7 +16977,7 @@ return static function (ContainerConfigurator $containerConfigurator): void {
     $services->set(ChangeConstantVisibilityRector::class)
         ->call('configure', [[
             ChangeConstantVisibilityRector::CLASS_CONSTANT_VISIBILITY_CHANGES => ValueObjectInliner::inline([
-                new ClassConstantVisibilityChange('ParentObject', 'SOME_CONSTANT', 2),
+                new ChangeConstantVisibility('ParentObject', 'SOME_CONSTANT', 2),
             ]),
         ]]);
 };

packages/rector-generator/templates/rules/__package__/tests/Rector/__Category__/__Name__/__Configured__Extra__Name__Test.php.inc

@@ -5,6 +5,7 @@ declare(strict_types=1);
 namespace Rector\__Package__\Tests\Rector\__Category__\__Name__;
 
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
 
 final class __Name__Test extends AbstractRectorTestCase
 {
@@ -22,14 +23,8 @@ final class __Name__Test extends AbstractRectorTestCase
         yield [new \Symplify\SmartFileSystem\SmartFileInfo(__DIR__ . '/Fixture/some_class.php.inc'), '__ExtraFileName__', __DIR__ . '/Source/extra_file.php'];
     }
 
-    /**
-     * @return mixed[]
-     */
-    protected function getRectorsWithConfiguration(): array
+    protected function provideConfigFileInfo(): ?\Symplify\SmartFileSystem\SmartFileInfo
     {
-        return [
-            \Rector\__Package__\Rector\__Category__\__Name__::class =>
-                __TestRuleConfiguration__
-        ];
+        return new \Symplify\SmartFileSystem\SmartFileInfo(__DIR__ . '/configured_rule.php');
     }
 }

packages/rector-generator/templates/rules/__package__/tests/Rector/__Category__/__Name__/__Configured__Name__Test.php.inc

@@ -21,14 +21,8 @@ final class __Name__Test extends AbstractRectorTestCase
         return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
-    /**
-     * @return mixed[]
-     */
-    protected function getRectorsWithConfiguration(): array
+    protected function provideConfigFileInfo(): ?\Symplify\SmartFileSystem\SmartFileInfo
     {
-        return [
-            \Rector\__Package__\Rector\__Category__\__Name__::class =>
-                __TestRuleConfiguration__
-        ];
+        return new \Symplify\SmartFileSystem\SmartFileInfo(__DIR__ . '/configured_rule.php');
     }
 }

packages/rector-generator/tests/RectorGenerator/Fixture/expected/rules/moderate-package/tests/Rector/MethodCall/WhateverRector/WhateverRectorTest.php.inc

@@ -21,14 +21,8 @@ final class WhateverRectorTest extends AbstractRectorTestCase
         return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
-    /**
-     * @return mixed[]
-     */
-    protected function getRectorsWithConfiguration(): array
+    protected function provideConfigFileInfo(): ?\Symplify\SmartFileSystem\SmartFileInfo
     {
-        return [
-            \Rector\ModeratePackage\Rector\MethodCall\WhateverRector::class =>
-                [\Rector\ModeratePackage\Rector\MethodCall\WhateverRector::CLASS_TYPE_TO_METHOD_NAME => ['SomeClass' => 'configure']]
-        ];
+        return new \Symplify\SmartFileSystem\SmartFileInfo(__DIR__ . '/configured_rule.php');
     }
 }

packages/rector-generator/tests/RectorGenerator/Fixture/expected_3rd_party/utils/rector/tests/Rector/MethodCall/WhateverRector/WhateverRectorTest.php.inc

@@ -21,14 +21,8 @@ final class WhateverRectorTest extends AbstractRectorTestCase
         return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
-    /**
-     * @return mixed[]
-     */
-    protected function getRectorsWithConfiguration(): array
+    protected function provideConfigFileInfo(): ?\Symplify\SmartFileSystem\SmartFileInfo
     {
-        return [
-            \Utils\Rector\Rector\MethodCall\WhateverRector::class =>
-                [\Utils\Rector\Rector\MethodCall\WhateverRector::CLASS_TYPE_TO_METHOD_NAME => ['SomeClass' => 'configure']]
-        ];
+        return new \Symplify\SmartFileSystem\SmartFileInfo(__DIR__ . '/configured_rule.php');
     }
 }

packages/testing/src/PHPUnit/AbstractRectorTestCase.php

@@ -20,7 +20,6 @@
 use Rector\Core\Stubs\StubLoader;
 use Rector\Core\ValueObject\PhpVersion;
 use Rector\Core\ValueObject\StaticNonPhpFileSuffixes;
-use Rector\Naming\Tests\Rector\Class_\RenamePropertyToMatchTypeRector\Source\ContainerInterface;
 use Rector\Testing\Application\EnabledRectorsProvider;
 use Rector\Testing\Contract\RunnableInterface;
 use Rector\Testing\Finder\RectorsFinder;
@@ -31,8 +30,6 @@
 use Rector\Testing\ValueObject\InputFilePathWithExpectedFile;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
-use Symfony\Component\DependencyInjection\Container;
-use Symfony\Component\HttpKernel\KernelInterface;
 use Symplify\EasyTesting\DataProvider\StaticFixtureFinder;
 use Symplify\EasyTesting\DataProvider\StaticFixtureUpdater;
 use Symplify\EasyTesting\StaticFixtureSplitter;
@@ -97,7 +94,7 @@ abstract class AbstractRectorTestCase extends AbstractKernelTestCase
     protected $originalTempFileInfo;
 
     /**
-     * @var Container|ContainerInterface|null
+     * @var SmartFileInfo
      */
     protected static $allRectorContainer;
 
@@ -125,7 +122,7 @@ protected function setUp(): void
         if ($this->provideConfigFileInfo() !== null) {
             $configFileInfos = $this->resolveConfigs($this->provideConfigFileInfo());
 
-            $this->bootKernelWithConfigInfos(RectorKernel::class, $configFileInfos);
+            $this->bootKernelWithConfigs(RectorKernel::class, $configFileInfos);
 
             $enabledRectorsProvider = $this->getService(EnabledRectorsProvider::class);
             $enabledRectorsProvider->reset();
@@ -198,31 +195,8 @@ protected function provideConfigFileInfo(): ?SmartFileInfo
         return null;
     }
 
-    /**
-     * @deprecated Use config instead, just to narrow 2 ways to add configured config to just 1. Now
-     * with PHP its easy pick.
-     *
-     * @return mixed[]
-     */
-    protected function getRectorsWithConfiguration(): array
-    {
-        // can be implemented, has the highest priority
-        return [];
-    }
-
-    /**
-     * @return mixed[]
-     */
     protected function getCurrentTestRectorClassesWithConfiguration(): array
     {
-        if ($this->getRectorsWithConfiguration() !== []) {
-            foreach (array_keys($this->getRectorsWithConfiguration()) as $rectorClass) {
-                $this->ensureRectorClassIsValid($rectorClass, 'getRectorsWithConfiguration');
-            }
-
-            return $this->getRectorsWithConfiguration();
-        }
-
         $rectorClass = $this->getRectorClass();
         $this->ensureRectorClassIsValid($rectorClass, 'getRectorClass');
 
@@ -251,37 +225,12 @@ protected function setParameter(string $name, $value): void
         $parameterProvider->changeParameter($name, $value);
     }
 
-    /**
-     * @deprecated Will be supported in Symplify 9
-     * @param SmartFileInfo[] $configFileInfos
-     */
-    protected function bootKernelWithConfigInfos(string $class, array $configFileInfos): KernelInterface
-    {
-        $configFiles = [];
-        foreach ($configFileInfos as $configFileInfo) {
-            $configFiles[] = $configFileInfo->getRealPath();
-        }
-
-        return $this->bootKernelWithConfigs($class, $configFiles);
-    }
-
     protected function getPhpVersion(): int
     {
         // to be implemented
         return self::PHP_VERSION_UNDEFINED;
     }
 
-    protected function assertFileMissing(string $temporaryFilePath): void
-    {
-        // PHPUnit 9.0 ready
-        if (method_exists($this, 'assertFileDoesNotExist')) {
-            $this->assertFileDoesNotExist($temporaryFilePath);
-        } else {
-            // PHPUnit 8.0 ready
-            $this->assertFileNotExists($temporaryFilePath);
-        }
-    }
-
     protected function doTestFileInfoWithoutAutoload(SmartFileInfo $fileInfo): void
     {
         $this->autoloadTestFixture = false;
@@ -518,6 +467,7 @@ private function createContainerWithAllRectors(): void
         $coreRectorClasses = $rectorsFinder->findCoreRectorClasses();
 
         $listForConfig = [];
+
         foreach ($coreRectorClasses as $rectorClass) {
             $listForConfig[$rectorClass] = null;
         }