Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Type->getIterableKeyType() over ArrayType->getKeyType() #6480

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Use Type->getIterableKeyType() over ArrayType->getKeyType() #6480

merged 1 commit into from
Nov 23, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Nov 23, 2024

similar to #6479

@samsonasik
Copy link
Member

Looking at ArrayType, getKeyType() vs getIterableKeyType() seems different logic, rather than call over another for equality.

@samsonasik
Copy link
Member

since CI green, let's give it a try, thank you @staabm

@samsonasik samsonasik merged commit 5b59337 into rectorphp:main Nov 23, 2024
36 checks passed
@staabm staabm deleted the it branch November 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @samsonasik