Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Skip compare nullable object on UseIdenticalOverEqualWithSameTypeRector #6474

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[CodeQuality] Skip compare nullable object on UseIdenticalOverEqualWithSameTypeRector #6474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fdb9e2
[CodeQuality] Skip compare nullable object on UseIdenticalOverEqualWi…
samsonasik Nov 22, 2024
e6633b5
fix
samsonasik Nov 22, 2024
b455a05
[ci-review] Rector Rectify
actions-user Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...qual/UseIdenticalOverEqualWithSameTypeRector/Fixture/skip_compare_nullable_object.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector\Fixture;

final class SkipCompareNullableObject
{
public function equal(?\DateTime $d, ?\DateTime $d2)
{
return $d == $d2;
}
}
3 changes: 1 addition & 2 deletions rules/CodeQuality/Rector/Equal/UseIdenticalOverEqualWithSameTypeRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use PhpParser\Node\Expr\BinaryOp\NotEqual;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PHPStan\Type\MixedType;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
Expand Down Expand Up @@ -69,7 +68,7 @@ public function refactor(Node $node): ?Node
$rightStaticType = $this->nodeTypeResolver->getNativeType($node->right);

// objects can be different by content
if ($leftStaticType instanceof ObjectType || $rightStaticType instanceof ObjectType) {
if (! $leftStaticType->isObject()->no() || ! $rightStaticType->isObject()->no()) {
return null;
}

Expand Down