[DX] Add default empty definition with add getRuleDefinition() method on AbstractRector #6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Comment on lines
+123
to
+127
| public function getRuleDefinition(): RuleDefinition | ||
| { | ||
| return new RuleDefinition('', []); | ||
| } | ||
|
|
There was a problem hiding this comment.
We'll still need a way to enforce adding this method in our rules. This would let it silently pass
There was a problem hiding this comment.
I see, I can add condition check for it :)
|
This definition is desired for our rules only, so it should not exist outside deployed |
|
We can handle the edge-case in our website. That's the only place where this method is required. Let's keep it is 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #6438 (review)
This avoid tricky patch via scoper, allow user to add whenever they want, or not if they don't want to, eg, when updating for laravel package, it required to show on our website.
see, tricky patch on website rectorphp/getrector-com@a4b9dee