[deprecation] Deprecate AbstractScopeAwareRector in favor of single AbstractRector #6425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With upcoming php-parser 5 and PHPStan 2 BC breaks, it's ideal time to cleanup some deprecated code and bad design choices :)
The
Rector\Rector\AbstractScopeAwareRector
is first of them. This "handy class" is too granular just to fetch single helper object. It makes creating new custom rules ambiguous, one layer more complex and confusing.It will be removed in favor of standard
AbstractRector
andScope
object can be fetched viaScopeFetcher
.That way you can use single class for all rules, and fetch scope when and where needed.