-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php84] Add rule for RoundingMode enum #6369
[Php84] Add rule for RoundingMode enum #6369
Conversation
...-tests/Php84/Rector/FuncCall/RoundingModeEnumRector/Fixture/do_not_reprint_node_type.php.inc
Outdated
Show resolved
Hide resolved
Just a quick read, if I understand correctly, the constant is not deprecated (yet) in php 8.4, it just replaced in core code, so I think it is not really needed for now. https://3v4l.org/Z40Kp/rfc#vgit.master when on future, the constant will be deprecated, eg: on php 8.5, we can create the rule to migrate it, if this is accepted, we need to prepare immediatelly the Downgrade |
It's unlikely that constants will be deprecated soon as it was the result of the RFC discussion. That's why I thought such a rule would help to speed up this process. |
I prefer to have downgrade rule instead first then, as replace constant is not required, but once it upgraded to enum, it needs to have downgrade rule to back to constant |
Makes sense. I will create a downgrade rule then. |
d77bfc9
to
54553da
Compare
Thank you @jorgsowa |
Adds new rule for replacing mode constants in the function round() with RoundingMode cases in PHP 8.4.
The PR is not finished, but please let me know whether it makes sense to add such a rule to the PHP8.4 ruleset.
Referenced RFC: https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum