[Php83] add type to final class constant #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbates35
force-pushed
the
add-type-const-final
branch
2 times, most recently
from
b2adf25 to
78a7443
Compare
philbates35
force-pushed
the
add-type-const-final
branch
from
78a7443 to
47ba28a
Compare
Since PHP8.1 it has been possible to mark a class constant as final. A "final public const FOO" should be treated the same as a "public const FOO" within a "final class" and the type should be added, which isn't currently the case.
philbates35
force-pushed
the
add-type-const-final
branch
from
47ba28a to
7842055
Compare
samsonasik
approved these changes
Feb 24, 2024
|
Thank you @philbates35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP8.1 it has been possible to mark a class constant as
final. Afinal public const FOOshould be treated the same as apublic const FOOwithin afinal classand the type should be added, which isn't currently the case.