[BetterPhpDocParser] Use ORIG_NODE attribute on DoctrineAnnotationDecorator on handle @\ after generic #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orator on handle @\ after generic
samsonasik
commented
Nov 25, 2023
Comment on lines
-21
to
+24
| $clonedNode->setAttribute(PhpDocAttributeKey::ORIG_NODE, $node); | ||
|
|
||
| if (! $clonedNode->hasAttribute(PhpDocAttributeKey::ORIG_NODE)) { | ||
| $clonedNode->setAttribute(PhpDocAttributeKey::ORIG_NODE, $node); | ||
| } |
There was a problem hiding this comment.
this is essential to ensure when orig node exists, no need to re-fill with node, use whatever ORIG_NODE value is, eg: null for reprint.
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of PR:
This utilize
ORIG_NODEattribute instead for reprint handling.