Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance][Testing] Avoid double call FileSystem::read() on AbstractRectorTestCase #4908

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

samsonasik
Copy link
Member

When calling:

$this->applicationFileProcessor->processFiles([$filePath], $configuration);

The CurrentFileProvider service is set to File object with its originalContent and new content, so we no longer need to re-read file.

This PR make pull from CurrentFileProvider service.

@samsonasik samsonasik closed this Sep 4, 2023
@samsonasik samsonasik reopened this Sep 4, 2023
@samsonasik samsonasik closed this Sep 4, 2023
@samsonasik samsonasik reopened this Sep 4, 2023
@samsonasik
Copy link
Member Author

Github action error seems unrelated:


Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_4ecd32f5-c361-435e-b74b-7171ccb18414/3c125ce6-395a-4023-acd8-39fc47eba947.tar.gz. return code: 2.

@samsonasik
Copy link
Member Author

It seems bug on github checkout:

I will try update to github checkout v4 on separate PR.

@samsonasik
Copy link
Member Author

Github actions/checkout updated to v4 on PR:

and this now rebased.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 4a3627e into main Sep 4, 2023
@samsonasik samsonasik deleted the remove-double-call branch September 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants