[DI] Remove symfony/dependency-injection dependency #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-less-symfony-dpes
branch
from
e067f64 to
f73ae8b
Compare
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-less-symfony-dpes
branch
from
c2a0185 to
4e113ef
Compare
|
Resulting build - dropped 32 000 lines 💪 rectorphp/rector@acc38e2
|
|
In order to determine the diff; given this PR solely is because of the removal, do we also have any idea how many lines were added because of the Laravel container? |
|
Depends what you try to compare. The Laravel container package was added in #4106, 1,5 month ago. This PR results in this diff: rectorphp/rector@9e10326 The container package itself: vendor/bin/lines measure vendor/illuminate/container --shortShows 1090 lines of code: ------------------------------ ---------------------
Metric Count
------------------------------ ---------------------
Directories 0
Files 6
------------------------------ ---------------------
------------------------------ ---------- ----------
Lines of code Count Relative
------------------------------ ---------- ----------
Code 1 090 56 %
Comments 855 44 %
Total 1 945 100 %
------------------------------ ---------- ----------
|
|
The same for Symfony would be: vendor/bin/lines measure vendor/symfony/dependency-injection --short↓ Filesystem count
Directories ......................................... 14
Files .............................................. 186
Lines of code count / relative
Code ................................... 17 694 / 79 %
Comments ................................ 4 698 / 21 %
Total .................................. 22 392 / 100 % |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4698
Before
After
↓
From 2 686 to 2 394 classes 🥳