Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SimplifyUselessVariableRector run without scope #4791

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Make SimplifyUselessVariableRector run without scope #4791

merged 1 commit into from
Aug 14, 2023

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 14, 2023 •
edited
Loading

Ref #4730

@samsonasik
Copy link
Member

Moving to AbstractRector is not solution, as if the unreachableSmt handling removed, the feature will no longer working after UnreachableSmt node

@TomasVotruba
Copy link
Member Author

This is to lower the dependency on scope in general, unrelated to the unreachable stmt.
Rules should work on new just created nodes as well.

@TomasVotruba TomasVotruba merged commit 685fe90 into main Aug 14, 2023
45 checks passed
@TomasVotruba TomasVotruba deleted the tv-avoid-scope-if-possible branch August 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomasVotruba @samsonasik