Adding a fixture #424
Merged
Adding a fixture #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rules-tests/Php74/Rector/Property/TypedPropertyRector/Fixture/michael_test.php.inc
Outdated
Show resolved
Hide resolved
|
It looks good 👍 I've added 2 details |
|
Still don't understand why I get inconsistent results as described by rectorphp/rector#6563 (comment), and how this fixture would shed any light. I am assuming that you don't want this test since it is already covered by https://github.com/rectorphp/rector-src/blob/main/rules-tests/Php74/Rector/Property/TypedPropertyRector/Fixture/property.php.inc, right? Should I close it or you? Thanks! |
|
The fixture is correct and now we have a clear confirmation. Merging to move forward 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see rectorphp/rector#6563. Sorry in advance if I am not doing this correctly. Thanks