Remove PARENT_NODE from CatchExceptionNameMatchingTypeRector #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-less-parent-15
branch
from
2a7912d to
6e650e3
Compare
samsonasik
reviewed
May 22, 2023
| { | ||
| if (rand(0, 1)) { | ||
| try { | ||
| } catch (SomeException $typoException) { |
There was a problem hiding this comment.
this PR cause a bug:
- } catch (SomeException $typoException) {
+ } catch (SomeException $someException) {which $typoException is variable that exists after jump if, to skip it, StmtsAwareInterface can be replaced with direct ClassMethod, Function_, Namespace_, FileWithoutNamespace, Closure which on top.
There was a problem hiding this comment.
I will create a PR for it :)
There was a problem hiding this comment.
Nested try/catch should be handled too.
I think this would cause a bug even for those on top. As we do not handle rename after.
If you find a better way without parent node, go for it 👍 Maybe custom node traversers is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector#7947