Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Keep Assign expr on RemoveUnusedVariableAssignRector for impure function #282

Merged
merged 4 commits into from
Jun 25, 2021
Merged

[DeadCode] Keep Assign expr on RemoveUnusedVariableAssignRector for impure function #282

merged 4 commits into from
Jun 25, 2021

Conversation

samsonasik
Copy link
Member

Remove variable of assign, but keep assign expr when assign expr is an impure function.

@samsonasik samsonasik force-pushed the impure-function-remove-unsed-variable-assign branch from 4e05d4a to 808b8fe Compare June 24, 2021 09:35
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik force-pushed the impure-function-remove-unsed-variable-assign branch from 808b8fe to 585eaeb Compare June 24, 2021 10:03
@samsonasik samsonasik force-pushed the impure-function-remove-unsed-variable-assign branch from 585eaeb to b45821d Compare June 25, 2021 05:42
@samsonasik
Copy link
Member Author

rebased, I submitted ob_get_clean to impure function to vimeo/psalm as well vimeo/psalm#5992 to sync.

@TomasVotruba TomasVotruba merged commit 6162f70 into main Jun 25, 2021
@TomasVotruba TomasVotruba deleted the impure-function-remove-unsed-variable-assign branch June 25, 2021 08:53
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba