[Php80] Returns null on no change on ClassPropertyAssignToConstructor…

…PromotionRector (#6418)
rectorphp · Nov 12, 2024 · d2db35e · d2db35e
1 parent 0cac71a
commit d2db35e
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php b/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
@@ -159,6 +159,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        $hasChanged = false;
         foreach ($promotionCandidates as $promotionCandidate) {
             $param = $promotionCandidate->getParam();
 
@@ -186,6 +187,8 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            $hasChanged = true;
+
             // remove property from class
             $propertyStmtKey = $property->getAttribute(AttributeKey::STMT_KEY);
             unset($node->stmts[$propertyStmtKey]);
@@ -249,6 +252,10 @@ public function refactor(Node $node): ?Node
             });
         }
 
+        if (! $hasChanged) {
+            return null;
+        }
+
         return $node;
     }