[Php70] More delimiter case in the middle fix on EregToPregMatchRector (

#6357)

* [Php70] More delimiter case in the middle fix on EregToPregMatchRector

* [Php70] More delimiter case in the middle fix on EregToPregMatchRector

rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/with_delimiter_char_in_middle2.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\Php70\Rector\FuncCall\EregToPregMatchRector\Fixture;
+
+function withDelimiterInMiddle2($text)
+{
+    return (bool) ereg('A# (minor|major)', $text);
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php70\Rector\FuncCall\EregToPregMatchRector\Fixture;
+
+function withDelimiterInMiddle2($text)
+{
+    return (bool) preg_match('#A\# (minor|major)#m', $text);
+}
+
+?>

rules/Php70/EregToPcreTransformer.php

@@ -71,19 +71,8 @@ public function __construct(
     ) {
     }
 
-    public function transform(string $ereg, bool $isCaseInsensitive): string
-    {
-        if (! \str_contains($ereg, $this->pcreDelimiter)) {
-            return $this->ere2pcre($ereg, $isCaseInsensitive);
-        }
-
-        // fallback
-        $quotedEreg = preg_quote($ereg, $this->pcreDelimiter);
-        return $this->ere2pcre($quotedEreg, $isCaseInsensitive);
-    }
-
     // converts the ERE $s into the PCRE $r. triggers error on any invalid input.
-    private function ere2pcre(string $content, bool $ignorecase): string
+    public function transform(string $content, bool $ignorecase): string
     {
         if ($ignorecase) {
             if (isset($this->icache[$content])) {
@@ -201,11 +190,16 @@ private function _ere2pcre(string $content, int $i): array
         }
 
         return [
-            str_replace($this->pcreDelimiter, '\\' . $this->pcreDelimiter, implode('|', $r)),
+            $this->normalize(implode('|', $r)),
             $i
         ];
     }
 
+    private function normalize(string $content): string
+    {
+        return str_replace($this->pcreDelimiter, '\\' . $this->pcreDelimiter, $content);
+    }
+
     /**
      * @param mixed[] $r
      */