[DeadCode] Allow remove assign variable with next method call on Remo…

…veDoubleAssignRector (#6443)

rules-tests/DeadCode/Rector/Assign/RemoveDoubleAssignRector/Fixture/next_reassign_with_call_on_variable.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\Fixture;
+
+class NextReassignWithCallOnVariable
+{
+    private $items;
+
+    public function create($input)
+    {
+        $items = $input;
+        $items = $this->getItems();
+    }
+
+    public function getItems()
+    {
+        return sort($this->items);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\Fixture;
+
+class NextReassignWithCallOnVariable
+{
+    private $items;
+
+    public function create($input)
+    {
+        $items = $this->getItems();
+    }
+
+    public function getItems()
+    {
+        return sort($this->items);
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Assign/RemoveDoubleAssignRector/Fixture/skip_next_reassign_with_call_on_property_fetch.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\Fixture;
+
+class SkipNextReassignWithCallOnPropertyFetch
+{
+    private $items;
+
+    public function create($input)
+    {
+        $this->items = $input;
+
+        $this->items = $this->getItems();
+    }
+
+    public function getItems()
+    {
+        return sort($this->items);
+    }
+}

rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php

@@ -6,7 +6,6 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\Assign;
-use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticPropertyFetch;
 use PhpParser\Node\Expr\Variable;
@@ -104,7 +103,10 @@ public function refactor(Node $node): ?Node
             }
 
             // next stmts can have side effect as well
-            if ($nextAssign->expr instanceof MethodCall) {
+            if (($nextAssign->var instanceof PropertyFetch || $nextAssign->var instanceof StaticPropertyFetch) && $this->sideEffectNodeDetector->detectCallExpr(
+                $nextAssign->expr,
+                $scope
+            )) {
                 continue;
             }