Remove SwapFuncCallArgumentsRector as keeps swaping to infinity, use …

…custom rule instead (#4874)

build/target-repository/docs/rector_rules_overview.md

@@ -1,10 +1,10 @@
-# 354 Rules Overview
+# 353 Rules Overview
 
 <br>
 
 ## Categories
 
-- [Arguments](#arguments) (5)
+- [Arguments](#arguments) (4)
 
 - [CodeQuality](#codequality) (70)
 
@@ -138,27 +138,6 @@ Replaces defined map of arguments in defined methods and their calls.
 
 <br>
 
-### SwapFuncCallArgumentsRector
-
-Reorder arguments in function calls
-
-:wrench: **configure it!**
-
-- class: [`Rector\Arguments\Rector\FuncCall\SwapFuncCallArgumentsRector`](../rules/Arguments/Rector/FuncCall/SwapFuncCallArgumentsRector.php)
-
-```diff
- final class SomeClass
- {
-     public function run()
-     {
--        return some_function('one', 'two', 'three');
-+        return some_function('three', 'two', 'one');
-     }
- }
-```
-
-<br>
-
 ## CodeQuality
 
 ### AbsolutizeRequireAndIncludePathRector

rules/Php80/Rector/Class_/AnnotationToAttributeRector.php

@@ -32,6 +32,7 @@
 use Rector\Php80\ValueObject\DoctrineTagAndAnnotationToAttribute;
 use Rector\PhpAttribute\NodeFactory\PhpAttributeGroupFactory;
 use Rector\PhpDocParser\PhpDocParser\PhpDocNodeTraverser;
+use Rector\RectorGenerator\Exception\ConfigurationException;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -118,6 +119,10 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        if ($this->annotationsToAttributes === []) {
+            throw new ConfigurationException(sprintf('The "%s" rule requires configuration.', self::class));
+        }
+
         $phpDocInfo = $this->phpDocInfoFactory->createFromNode($node);
         if (! $phpDocInfo instanceof PhpDocInfo) {
             return null;

tests/Issues/ConstructorPromoAnnotationToAttribute/config/configured_rule.php

@@ -3,10 +3,14 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+
 use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
+use Rector\Php80\ValueObject\AnnotationToAttribute;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(ClassPropertyAssignToConstructorPromotionRector::class);
-    $rectorConfig->rule(AnnotationToAttributeRector::class);
+    $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
+        new AnnotationToAttribute('OldTag', 'NewAttribute'),
+    ]);
 };

utils/Command/OutsideAnySetCommand.php

@@ -35,10 +35,25 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $rectorClassesOutsideAnySet = array_diff($existingRectorClasses, $setDefinedRectorClasses);
 
-        sort($rectorClassesOutsideAnySet);
+        // skip transform rules, as designed for custom use
+        $filteredRectorClassesOutsideAnySet = array_filter(
+            $rectorClassesOutsideAnySet,
+            static function (string $rectorClass): bool {
+                if (str_contains($rectorClass, '\\Transform\\')) {
+                    return false;
+                }
 
-        $this->symfonyStyle->listing($rectorClassesOutsideAnySet);
-        $this->symfonyStyle->warning(sprintf('%d rules is outside any set', count($rectorClassesOutsideAnySet)));
+                // skip renaming rules too, as designed for custom use
+                return ! str_contains($rectorClass, '\\Renaming\\');
+            }
+        );
+
+        sort($filteredRectorClassesOutsideAnySet);
+
+        $this->symfonyStyle->listing($filteredRectorClassesOutsideAnySet);
+        $this->symfonyStyle->warning(
+            sprintf('%d rules is outside any set', count($filteredRectorClassesOutsideAnySet))
+        );
 
         return self::SUCCESS;
     }