make sure PHPStan cache directory is configurable and created

rectorphp · Aug 17, 2023 · 84d4fe5 · 84d4fe5
1 parent 4637080
commit 84d4fe5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/packages/Config/RectorConfig.php b/packages/Config/RectorConfig.php
@@ -280,7 +280,7 @@ public function cacheDirectory(string $directoryPath): void
     }
 
     /**
-     * @info Rector no longer user compiled container, but Laravel lazy one.
+     * @info Rector no longer uses compiled container, but Laravel lazy one.
      * This option is for PHPStan container in case the sys_get_temp_dir() is not available for the current user.
      */
     public function containerCacheDirectory(string $directoryPath): void

diff --git a/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php b/packages/NodeTypeResolver/DependencyInjection/PHPStanServicesFactory.php
@@ -47,12 +47,13 @@ public function __construct(
             $purifiedConfigFiles[] = $purifiedConfigFile;
         }
 
+        $cacheDirectory = SimpleParameterProvider::provideStringParameter(Option::CACHE_DIR);
+
+        // make sure directory exists as PHPStan Nette container will not create it and crash
+        \Nette\Utils\FileSystem::createDir($cacheDirectory);
+
         $containerFactory = new ContainerFactory(getcwd());
-        $this->container = $containerFactory->create(
-            sys_get_temp_dir() . '/phpstan-container-for-rector',
-            $additionalConfigFiles,
-            []
-        );
+        $this->container = $containerFactory->create($cacheDirectory, $additionalConfigFiles, []);
 
         // clear temporary files, after container is created
         $filesystem = new Filesystem();

diff --git a/src/DependencyInjection/LazyContainerFactory.php b/src/DependencyInjection/LazyContainerFactory.php
@@ -399,9 +399,6 @@ public function create(): RectorConfig
 
         $rectorConfig->cacheDirectory(sys_get_temp_dir() . '/rector_cached_files');
 
-        // cache directory for PHPStan container
-        $rectorConfig->containerCacheDirectory(sys_get_temp_dir());
-
         // make use of https://github.com/symplify/easy-parallel
         $rectorConfig->singleton(Application::class, static function (): Application {
             $application = new Application();