[NodeTypeResolver] No need json_decode/json_encode for cache class na…

…me collection (#5881)
rectorphp · May 15, 2024 · 6bd2b87 · 6bd2b87
1 parent 3cf5b1a
commit 6bd2b87
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/src/FamilyTree/Reflection/FamilyRelationsAnalyzer.php b/src/FamilyTree/Reflection/FamilyRelationsAnalyzer.php
@@ -109,14 +109,11 @@ private function loadClasses(): void
         $key = $this->dynamicSourceLocatorProvider->getCacheClassNameKey();
         $classNamesCache = $this->cache->load($key, CacheKey::CLASSNAMES_HASH_KEY);
 
-        if (is_string($classNamesCache)) {
-            $classNamesCache = json_decode($classNamesCache);
-            if (is_array($classNamesCache)) {
-                foreach ($classNamesCache as $classNameCache) {
-                    try {
-                        $this->reflectionProvider->getClass($classNameCache);
-                    } catch (ClassNotFoundException) {
-                    }
+        if (is_array($classNamesCache)) {
+            foreach ($classNamesCache as $classNameCache) {
+                try {
+                    $this->reflectionProvider->getClass($classNameCache);
+                } catch (ClassNotFoundException) {
                 }
             }
         }

diff --git a/...solver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php b/...solver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php
@@ -146,7 +146,7 @@ private function collectClasses(AggregateSourceLocator $aggregateSourceLocator,
         $key = $this->getCacheClassNameKey();
         $classNamesCache = $this->cache->load($key, CacheKey::CLASSNAMES_HASH_KEY);
 
-        if (is_string($classNamesCache)) {
+        if (is_array($classNamesCache)) {
             return;
         }
 
@@ -162,6 +162,6 @@ private function collectClasses(AggregateSourceLocator $aggregateSourceLocator,
         } catch (CouldNotReadFileException) {
         }
 
-        $this->cache->save($key, CacheKey::CLASSNAMES_HASH_KEY, json_encode($classNames));
+        $this->cache->save($key, CacheKey::CLASSNAMES_HASH_KEY, $classNames);
     }
 }