YieldDataProviderRector: added failling test #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 9, 2024
...eQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc
Outdated
Show resolved
Hide resolved
…Fixture/use_data_provider_with_phpdoc.php.inc Co-authored-by: Abdul Malik Ikhsan <[email protected]>
|
@samsonasik could you have a look into the rule? |
|
I will try 👍 |
staabm
commented
Dec 9, 2024
| ]; | ||
| } | ||
|
|
||
| public static function dataProvider() |
There was a problem hiding this comment.
At this provider we could add another case with list<...>
|
@staabm I cherry-picked your commit at PR |
samsonasik
added a commit
that referenced
this pull request
Dec 9, 2024
…oviderRector (#415) * YieldDataProviderRector: added failling test * Update use_data_provider_with_phpdoc.php.inc * Update rules-tests/CodeQuality/Rector/Class_/YieldDataProviderRector/Fixture/use_data_provider_with_phpdoc.php.inc Co-authored-by: Abdul Malik Ikhsan <[email protected]> * Closes #414 --------- Co-authored-by: Markus Staab <[email protected]> Co-authored-by: Markus Staab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful, if rector transforms a
arrayreturn type into aIterator, that it also fixes a possible@returnphpdoc type of a dataprovider (otherwise PHPStan is starting to yell about incompatible native vs. phpdoc return-type