Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MovieLens URL from HTTP to HTTPS #1677

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Change MovieLens URL from HTTP to HTTPS #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/00_quick_start/ncf_movielens.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"name": "stderr",
"output_type": "stream",
"text": [
"INFO:recommenders.datasets.download_utils:Downloading http://files.grouplens.org/datasets/movielens/ml-100k.zip\n",
"INFO:recommenders.datasets.download_utils:Downloading https://files.grouplens.org/datasets/movielens/ml-100k.zip\n",
"100%|██████████| 4.81k/4.81k [00:00<00:00, 16.9kKB/s]\n"
]
}
Expand Down
2 changes: 1 addition & 1 deletion examples/01_prepare_data/data_split.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"cell_type": "code",
"execution_count": 4,
"source": [
"DATA_URL = \"http://files.grouplens.org/datasets/movielens/ml-100k/u.data\"\n",
"DATA_URL = \"https://files.grouplens.org/datasets/movielens/ml-100k/u.data\"\n",
"DATA_PATH = \"ml-100k.data\"\n",
"\n",
"COL_USER = \"UserId\"\n",
Expand Down
2 changes: 1 addition & 1 deletion examples/02_model_hybrid/lightfm_deep_dive.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@
}
],
"source": [
"user_feature_URL = 'http://files.grouplens.org/datasets/movielens/ml-100k/u.user'\n",
"user_feature_URL = 'https://files.grouplens.org/datasets/movielens/ml-100k/u.user'\n",
"user_data = pd.read_table(user_feature_URL, \n",
" sep='|', header=None)\n",
"user_data.columns = ['userID','age','gender','occupation','zipcode']\n",
Expand Down
10 changes: 5 additions & 5 deletions recommenders/datasets/movielens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ def load_pandas_df(
):
"""Loads the MovieLens dataset as pd.DataFrame.

Download the dataset from http://files.grouplens.org/datasets/movielens, unzip, and load.
Download the dataset from https://files.grouplens.org/datasets/movielens, unzip, and load.
To load movie information only, you can use load_item_df function.

Args:
Expand Down Expand Up @@ -304,7 +304,7 @@ def _load_item_df(size, item_datapath, movie_col, title_col, genres_col, year_co
genres_header_100k = None
if genres_col is not None:
# 100k data's movie genres are encoded as a binary array (the last 19 fields)
# For details, see http://files.grouplens.org/datasets/movielens/ml-100k-README.txt
# For details, see https://files.grouplens.org/datasets/movielens/ml-100k-README.txt
if size == "100k":
genres_header_100k = [*(str(i) for i in range(19))]
item_header.extend(genres_header_100k)
Expand Down Expand Up @@ -366,7 +366,7 @@ def load_spark_df(
):
"""Loads the MovieLens dataset as `pyspark.sql.DataFrame`.

Download the dataset from http://files.grouplens.org/datasets/movielens, unzip, and load as `pyspark.sql.DataFrame`.
Download the dataset from https://files.grouplens.org/datasets/movielens, unzip, and load as `pyspark.sql.DataFrame`.

To load movie information only, you can use `load_item_df` function.

Expand Down Expand Up @@ -552,7 +552,7 @@ def download_movielens(size, dest_path):
if size not in DATA_FORMAT:
raise ValueError(ERROR_MOVIE_LENS_SIZE)

url = "http://files.grouplens.org/datasets/movielens/ml-" + size + ".zip"
url = "https://files.grouplens.org/datasets/movielens/ml-" + size + ".zip"
dirs, file = os.path.split(dest_path)
maybe_download(url, file, work_directory=dirs)

Expand Down Expand Up @@ -587,7 +587,7 @@ class MockMovielensSchema(pa.SchemaModel):
Mock dataset schema to generate fake data for testing purpose.
This schema is configured to mimic the Movielens dataset

http://files.grouplens.org/datasets/movielens/ml-100k/
https://files.grouplens.org/datasets/movielens/ml-100k/

Dataset schema and generation is configured using pandera.
Please see https://pandera.readthedocs.io/en/latest/schema_models.html
Expand Down