Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review SVD results #280

Closed
miguelgfierro opened this issue Nov 22, 2018 · 3 comments
Closed

Review SVD results #280

miguelgfierro opened this issue Nov 22, 2018 · 3 comments
Assignees
@anargyri
Labels
bug Something isn't working high priority
Milestone
Open Source Release

Comments

@miguelgfierro
Copy link
Collaborator

miguelgfierro commented Nov 22, 2018 •
edited
Loading

https://github.com/Microsoft/Recommenders/blob/staging/notebooks/02_modeling/surprise_svd_deep_dive.ipynb
@miguelgfierro miguelgfierro added this to the Open Source Release milestone Nov 22, 2018
@anargyri anargyri added bug Something isn't working high priority labels Nov 22, 2018
@anargyri
Copy link
Collaborator

anargyri commented Nov 22, 2018 •
edited
Loading

There is a bug in the Surprise SVD notebook. See cells 4 and 5.
In cell 5, train is assigned to the full data Movielens100K data set. So, if you do train.n_ratings you get 100K. Then SVD is trained on the whole data set and hence the results are too good, because the test set is a subset of the training set.

@miguelgfierro
Copy link
Collaborator Author

Great catch Andreas!

@anargyri anargyri mentioned this issue Nov 23, 2018
Merged
@anargyri
Copy link
Collaborator

Resolved in #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anargyri anargyri

Labels
bug Something isn't working high priority
Projects
None yet
Milestone
Open Source Release
Development

No branches or pull requests
2 participants
@miguelgfierro @anargyri