We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a bug in the negative_feedback_sampler function https://github.com/microsoft/recommenders/blob/837b8081a4421e144f2bc05ba949c5ac6c52320f/reco_utils/dataset/pandas_df_utils.py#L267. Although the function includes parameters col_user and col_item, these are not passed through to user_item_pairs in line 324. This causes an error if non-default values for col_user and col_item are passed to negative_feedback_sampler ('userID' and 'itemID' respectively).
Azure Linux DSVM
Call negative_feedback_sampler with any values other than col_user="userID" and col_item="itemID"
User should be able to pass user-defined column names into negative_feedback_sampler
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
There is a bug in the negative_feedback_sampler function https://github.com/microsoft/recommenders/blob/837b8081a4421e144f2bc05ba949c5ac6c52320f/reco_utils/dataset/pandas_df_utils.py#L267. Although the function includes parameters col_user and col_item, these are not passed through to user_item_pairs in line 324. This causes an error if non-default values for col_user and col_item are passed to negative_feedback_sampler ('userID' and 'itemID' respectively).
In which platform does it happen?
Azure Linux DSVM
How do we replicate the issue?
Call negative_feedback_sampler with any values other than col_user="userID" and col_item="itemID"
Expected behavior (i.e. solution)
User should be able to pass user-defined column names into negative_feedback_sampler
The text was updated successfully, but these errors were encountered: