Update build.gradle to allow override of MS auth library version. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is the least impact in terms of blast radius. I can also update the docs with a caveat that changing the library version may break the plugin.
|
This addresses issue #42. |
|
This PR is ready for review! |
|
@bartwesselink Could I get a review on this PR 👍/👎? |
wslaghekke
approved these changes
Aug 7, 2024
macdja38
pushed a commit
to fellowapp/capacitor-plugin-msauth
that referenced
this pull request
Nov 19, 2024
…cognizegroup#43) * Update build.gradle to allow override of MS auth library version. I think this is the least impact in terms of blast radius. I can also update the docs with a caveat that changing the library version may break the plugin. * Update README.md with explanation. * Update build.gradle to use namespaced var name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this change has the least impact in terms of blast radius, while still allowing for a quick fix. I can also update the docs with a caveat that changing the library version may break the plugin. Let me know what you all think.