Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated IIIF handling from manifesto.js to @allmaps/iiif-parser #217

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

rsimon
Copy link
Member

@rsimon rsimon commented Jul 11, 2024

In this PR

This PR migrates all IIIF handling code from the (brittle...) manifesto.js to the @allmaps/iiif-parser.

@rsimon rsimon requested a review from lwjameson July 11, 2024 07:31
@rsimon rsimon marked this pull request as ready for review July 11, 2024 07:31
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for vico-design ready!

Name Link
🔨 Latest commit c714c64
🔍 Latest deploy log https://app.netlify.com/sites/vico-design/deploys/668f8a5024638f0008abfb72
😎 Deploy Preview https://deploy-preview-217--vico-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for recogito-cloud-staging ready!

Name Link
🔨 Latest commit c714c64
🔍 Latest deploy log https://app.netlify.com/sites/recogito-cloud-staging/deploys/668f8a50111d2e000848ec2c
😎 Deploy Preview https://deploy-preview-217--recogito-cloud-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@lwjameson lwjameson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rsimon rsimon merged commit cfb386d into develop Jul 12, 2024
8 checks passed
@rsimon rsimon deleted the rs/iiif-fixes branch July 12, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants