This repository has been archived by the owner on Oct 5, 2020. It is now read-only.
Fixup goclient upgrade #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanlindauer
previously approved these changes
Dec 27, 2017
bethge
force-pushed
the
fixup-goclient-upgrade
branch
2 times, most recently
from
99440a0 to
40dc349
Compare
octopusx
previously approved these changes
Dec 27, 2017
svenwltr
reviewed
Jan 2, 2018
pkg/api/render_test.go
Outdated
|
|
||
| func TestDecode(t *testing.T) { | ||
| tcs := map[string]string{ | ||
| "podpreset.yaml": ` |
There was a problem hiding this comment.
I would put this into an actual file.
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/rebuy-de/kubernetes-deployment/pkg/templates" | |||
| log "github.com/sirupsen/logrus" | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| "k8s.io/client-go/pkg/api" | |||
| "k8s.io/client-go/kubernetes/scheme" | |||
There was a problem hiding this comment.
Can you check if this is still required:
kubernetes-deployment/pkg/api/init.go
Lines 8 to 17 in 8c23e8d
There was a problem hiding this comment.
Appears to no longer be needed.
bethge
force-pushed
the
fixup-goclient-upgrade
branch
2 times, most recently
from
15d7bb6 to
fe07a81
Compare
svenwltr
reviewed
Jan 2, 2018
pkg/api/render_test.go
Outdated
| func TestDecode(t *testing.T) { | ||
| dir := "test-fixtures" | ||
| tcs := map[string]string{ | ||
| "manifest-deployment.yaml": "", |
There was a problem hiding this comment.
What do you think about this:
"manifest-deployment.yaml": readFile(t, path.Join(dir, "manifest-deployment.yaml")),
There was a problem hiding this comment.
yeah, that works too and is more succinct.
bethge
force-pushed
the
fixup-goclient-upgrade
branch
from
fe07a81 to
8df185d
Compare
svenwltr
previously approved these changes
Jan 2, 2018
bethge
force-pushed
the
fixup-goclient-upgrade
branch
from
0274767 to
054c017
Compare
bethge
dismissed stale reviews from stephanlindauer, svenwltr, and octopusx
added file struct
|
@rebuy-de/prp-kubernetes-deployment - PTAL |
svenwltr
approved these changes
Jan 3, 2018
stephanlindauer
approved these changes
Jan 3, 2018
octopusx
approved these changes
Jan 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rebuy-de/prp-kubernetes-deployment - PTAL
Some of the capabilities for decoding manifests have moved to
client-go/kubernetes/schema.Separated
app.Renderfor easier testability ofscheme.Codecs.UniversalDeserializer().Decode().pkg/api/render_test.gois not pretty. On the upside: no added file i/o in the "unit test". Very much open to suggestions.See: