Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add flags for exporter http timeout and log level #10

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Add flags for exporter http timeout and log level #10

merged 2 commits into from
Apr 18, 2019

Conversation

phsm
Copy link
Contributor

@phsm phsm commented Apr 15, 2019

Hi,
Another pull request to add flags for http timeout for connecting to exporter, and log level.

Warning! do not merge yet, I need your help with "log-level" flag. For some reason it always takes the default value (exporter timeout works)

@phsm phsm requested a review from a team April 15, 2019 17:56
Copy link
Member

@svenwltr svenwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prever a verbose|v flag over a log-level flag. In my experience I have always to look up how log levels work for each program, while verbose flags are usable out-of-the box.

What is a possible reason to hide Info levels?

cmd/command.go Outdated Show resolved Hide resolved
@phsm
Copy link
Contributor Author

phsm commented Apr 18, 2019

As suggested, added "verbose" flag instad of log-level, which changes loglevel from Info (default) to debug.
Tested both of the new options: invoking via flag, and using env variable.

@svenwltr svenwltr requested a review from a team April 18, 2019 08:06
@bjoernhaeuser bjoernhaeuser merged commit 92609a1 into rebuy-de:master Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants