This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Refactor AWS account validation #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethge
reviewed
Jan 6, 2018
cmd/config_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
|
|
||
| config, err := LoadConfig(path.Join(cwd, "..", "config", "example.yaml")) |
There was a problem hiding this comment.
Somewhat conflicted about using an example file as a test input. It does make sure that the example is valid to some degree. On the other hand it is really unexpected to have an example be part of a test case.
I do not have much experience with generated documentation, but I feel like this would be another potential use case for it (besides the documentation of supported AWS resources).
There was a problem hiding this comment.
I had the same doubts. I added another test config for the tests.
cmd/config.go
Outdated
| @@ -51,6 +53,40 @@ func (c *NukeConfig) InBlacklist(searchID string) bool { | |||
| return false | |||
| } | |||
|
|
|||
| func (c *NukeConfig) ValidateAccount(accountID string, aliases []string) (*NukeConfigAccount, error) { | |||
There was a problem hiding this comment.
Imho, I liked the old signature of ValidateAccount, where it only validates and returns error(s).
There was a problem hiding this comment.
That's very true. Fixed.
bethge
approved these changes
Jan 6, 2018
stephanlindauer
approved these changes
Jan 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awsutilpackage to slim downcmdpackageNuketo the actual config struct@rebuy-de/prp-aws-nuke Please review.
This is a preparation for #66.