Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Let aws-nuke container run as non-root user #352

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Let aws-nuke container run as non-root user #352

merged 1 commit into from
Apr 17, 2019

Conversation

der-eismann
Copy link
Member

No description provided.

@der-eismann der-eismann requested a review from a team April 17, 2019 09:28
@svenwltr
Copy link
Member

Not sure how much of a breaking change this is. If someone copies a config into the container, which is not readable by the new user, it will break.

@der-eismann
Copy link
Member Author

That is true. I would argue that normally all files are at least 644, but I get that aws credentials are a bit sensitive. So... what do?

@svenwltr
Copy link
Member

I guess adding a Breaking Change section to the next release should be enough.

@der-eismann der-eismann merged commit f34822c into master Apr 17, 2019
@der-eismann der-eismann deleted the non-root branch April 17, 2019 09:54
@svenwltr svenwltr added the kind/enhancement New core feature or improvement of existing ones. label May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@svenwltr svenwltr svenwltr approved these changes

@stephanlindauer stephanlindauer stephanlindauer approved these changes

Assignees
No one assigned
Labels
kind/enhancement New core feature or improvement of existing ones.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@der-eismann @svenwltr @stephanlindauer