-
Notifications
You must be signed in to change notification settings - Fork 725
Conversation
pkg/awsutil/session.go
Outdated
} | ||
|
||
switch { | ||
case c.HasProfile() && c.HasKeys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of throwing an error if neither are present, you now only throw one if both are present. Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Fixed.
What's the breaking change @svenwltr ? |
@tomvachon That the user has to add |
@svenwltr agreed, I wonder could it be a boolean in the config and default it to "true"?
|
@tomvachon What is the benefit of introducing a new config flag over adding it to the region list? |
@svenwltr Either people will forget about it or more importantly, it shows its a "meta-region". Someone will stumble on this project and wonder why "global" is a region IMO |
@rebuy-de/prp-aws-nuke Your opinions on this? |
I would suggest to introduce the mentioned |
@svenwltr @bethge @bjoernhaeuser This may become more urgent, it seems like S3 buckets aren't working. I just noticed |
@tomvachon What to you mean by not working? |
They aren’t being deleted. They show up in the list (confirmed in verbose)
but nothing is deleted
…On Wed, Mar 14, 2018 at 2:01 PM Sven Walter ***@***.***> wrote:
@tomvachon <https://github.com/tomvachon> What to you mean by not working?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUQRQRX1DmAV-3OvI4GCfac1uICdwngks5teVr-gaJpZM4SqDO8>
.
|
@tomvachon deleting S3Buckets works for me with this branch and with current master. Can you give more details about the error? |
@svenwltr Here is the full output
Here is the list-buckets
|
Ok, this is, because the bucket location somehow is empty. Not sure how this happened. I though buckets always have a location. I will add a handling for that case. |
See also |
@svenwltr ok, these were made a variety of ways, including API, Console, and Wizards Ah, I found the cause @svenwltr https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketGETlocation.html#RESTBucketGETlocation-responses-response-elements TL;DR: "When the bucket's region is US East (N. Virginia), Amazon S3 returns an empty string for the bucket's region" |
I will fix this in another PR, since it is unrelated to global regions. |
This is a breaking change and will cause a new major version.
@rebuy-de/prp-aws-nuke Please review.
/cc @tomvachon