This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three new modules and four updated modules for AWS Comprehend.
Adding
Completed
to the job status types that are ignored upon cleanup for all Comprehend job types.Adding support for the following job types:
ComprehendEventsDetectionJob
,ComprehendPiiEntititesDetectionJob
, andComprehendTargetedSentimentDetectionJob
Testing
Comprehend resources were created using the setup code mentioned below, and then AWS Nuke was used to clean these resources up, specifying
"ComprehendDominantLanguageDetectionJob"
"ComprehendEntitiesDetectionJob"
"ComprehendEventsDetectionJob"
"ComprehendKeyPhrasesDetectionJob"
"ComprehendPiiEntititesDetectionJob"
"ComprehendSentimentDetectionJob"
"ComprehendTargetedSentimentDetectionJob"
Resources in the
Completed
state no longer cause Nuke to error. These don't actually get deleted as they are just metadata pointing to the trained files in S3. The original function goal was to stop in progress jobs, but they missed filtering out those in theCompleted
status so they were causing errors because they were in the wrong state upon running nuke against these resource types.Setup code