Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Fix date format for ASG creationDate #1014

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

vboulineau
Copy link
Contributor

#769 introduced a new Time format 2006-01-02 15:04:05.000 -0700 MST which requires 3 digits for decimal seconds, making date like 2023-05-17 10:01:12.14 +0000 UTC failing to parse.
Fixing the filter to parse any decimal second.

However the filter should never have been added as it's the property that should be correctly serialized to a string (and not relying on Go default time.Time to string print) the same way as it's done for EC2Instance for instance.

Leaving the fixed date format just in case it's used somewhere else.

@vboulineau vboulineau requested a review from a team as a code owner May 31, 2023 11:00
@vboulineau
Copy link
Contributor Author

@der-eismann @svenwltr Would it be possible to have a review on this PR? It basically prevent aws-nuke to work for ASG with Date filter and the fix is really simple.

@bjoernhaeuser bjoernhaeuser enabled auto-merge (squash) August 2, 2023 08:39
@bjoernhaeuser bjoernhaeuser merged commit 34899fb into rebuy-de:main Aug 2, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants