Fix crash when WAF/WAFRegional GetRule gives error (#894)

rebuy-de · Aug 29, 2023 · 5560ce3 · 5560ce3
1 parent ac386b8
commit 5560ce3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/resources/waf-rules.go b/resources/waf-rules.go
@@ -32,9 +32,12 @@ func ListWAFRules(sess *session.Session) ([]Resource, error) {
 		}
 
 		for _, rule := range resp.Rules {
-			ruleResp, _ := svc.GetRule(&waf.GetRuleInput{
+			ruleResp, err := svc.GetRule(&waf.GetRuleInput{
 				RuleId: rule.RuleId,
 			})
+			if err != nil {
+				return nil, err
+			}
 			resources = append(resources, &WAFRule{
 				svc:  svc,
 				ID:   rule.RuleId,

diff --git a/resources/wafregional-rules.go b/resources/wafregional-rules.go
@@ -34,9 +34,12 @@ func ListWAFRegionalRules(sess *session.Session) ([]Resource, error) {
 		}
 
 		for _, rule := range resp.Rules {
-			ruleResp, _ := svc.GetRule(&waf.GetRuleInput{
+			ruleResp, err := svc.GetRule(&waf.GetRuleInput{
 				RuleId: rule.RuleId,
 			})
+			if err != nil {
+				return nil, err
+			}
 			resources = append(resources, &WAFRegionalRule{
 				svc:  svc,
 				ID:   rule.RuleId,