Feature/auto bid #15
Feature/auto bid #15
Conversation
- Update Bid Schema - Add validation for incoming BId max_bid_price, to ensure that if used, it is not equal or lower than price (the minimum price). - Update returned bid json to include a max_bid_price
After creating a new bid, bid controller `handle_auto_bids` will take the item id, grab all current active auto bids for the item, then iterate through each and create new bids for that user if the new price increment is less than the users maximum bid price. It will continue this recursive check until there is one auto bid left (aka, there is no more competing auto bid requests). It also makes sure that a user doesn't double bid accidentally.
| defp handle_auto_bids(item_id) do | ||
| item_id | ||
| |> UserItem.get_auto_bids_by_item | ||
| |> run_auto_bids(item_id) |
There was a problem hiding this comment.
This may be nitpicky, but I think it makes for better readability to implement pipelines when the same message is being passed through. So passing in item_id to a function that returns a collection of bids that get passed to run_auto_bids doesn't read as well to me as something more like UserItem.get_auto_bids_by_item(item_id) |> run_auto_bids(item_id). Such a minor thing here, but I think it becomes more helpful with more complicated pipelines.
| |> UserItem.get_auto_bids_by_item | ||
| |> run_auto_bids(item_id) | ||
|
|
||
| case length(item_id |> UserItem.get_auto_bids_by_item) do |
There was a problem hiding this comment.
Could you reduce duplication and improve readability by assigning the collection of bids to a variable?
|
|
||
| defp run_auto_bids(bids, item_id) do | ||
| bids | ||
| |> Enum.each(fn bid -> |
There was a problem hiding this comment.
I believe Elixir pattern-matching can be leveraged recursively to the same effect, if you want to do this more idiomatically than with the use of each.
| UserItem.create_bid(new_bid) | ||
| end | ||
| end) | ||
| end |
There was a problem hiding this comment.
The auto-bidding functionality may be worth extracting to a separate module. The controller should really just be concerned with handling requests.
Things Done