Fix multi-child fragment #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
reviewed
Aug 15, 2024
|
Nice, thanks! 🤗 |
anmonteiro
force-pushed
the
fix-multichild-fragment
branch
from
90ee9f8 to
5f83a0d
Compare
anmonteiro
approved these changes
Aug 16, 2024
This was referenced Aug 16, 2024
jchavarri
added a commit
to jchavarri/opam-repository
that referenced
this pull request
Aug 19, 2024
CHANGES: * Add `isValidElement` (@r17x in reasonml/reason-react#837) * Add `startTransition` (@r17x in reasonml/reason-react#838) * Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in [reasonml/reason-react#839](reasonml/reason-react#839)) * Add CSS Box Alignment Module Level 3 (@davesnx in reasonml/reason-react#847) * Fix: Remove "unique `key` prop" warnings from multi-child fragment elements (@jchavarri in reasonml/reason-react#852)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: * Add `isValidElement` (@r17x in reasonml/reason-react#837) * Add `startTransition` (@r17x in reasonml/reason-react#838) * Convert `ReasonReactErrorBoundary` to Reason instead of `%raw` JS. This has the benefit of skipping a hardcoded `require('react')` call (@anmonteiro in [reasonml/reason-react#839](reasonml/reason-react#839)) * Add CSS Box Alignment Module Level 3 (@davesnx in reasonml/reason-react#847) * Fix: Remove "unique `key` prop" warnings from multi-child fragment elements (@jchavarri in reasonml/reason-react#852)
davesnx
added a commit
that referenced
this pull request
Nov 18, 2024
* 'main' of github.com:/reasonml/reason-react: fix: type of pipeable stream to allow objects with keys (#854) reason-react-ppx: + lower bound in ocaml add missing entries to changelog Fix multi-child fragment (#852) update compiler version in makefile cmd (#851) Add locations-check test (#844) fix: re-enable failing tests + fix location tests (#850) test: repro #840 (#842) Add CSS Box Alignment Module Level 3 (#847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this code
<> <div/> <div/> </>will trigger the infamous warning:Each child in a list should have a unique "key" prop.This PR modifies the expression switch for fragments so that those with 0 or 1 child use
jsxand those with 2 or more children usejsxs.