This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Make compatible with GraphQL PPX 1.0 beta #117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakenickels
reviewed
Apr 21, 2020
src/ApolloClient.re
Outdated
| @@ -0,0 +1,128 @@ | |||
| open ReasonApolloTypes; | |||
There was a problem hiding this comment.
would be amazing if this would be moved to another package so reason-apollo and reason-apollo-hooks could share the same ApolloClient definitions
There was a problem hiding this comment.
Probably better to have a single package, because the hooks are now also part of the same @apollo/client package.
26 tasks
jeddeloh
reviewed
May 7, 2020
src/ApolloHooksSubscription.re
Outdated
| }; | ||
|
|
||
| [@bs.module "@apollo/client"] | ||
| external useSubscription: | ||
| (ReasonApolloTypes.queryString, options('raw_t)) => | ||
| (ReasonApolloTypes.queryString, options('raw_t, 'raw_t_variables)) => | ||
| { | ||
| . | ||
| "data": Js.Nullable.t(Js.Json.t), |
There was a problem hiding this comment.
I think this needs to be "data": Js.Nullable.t('raw_t),?
This was referenced May 7, 2020
10 tasks
|
When I tried to use this branch I got confused because the readme still states to install and use |
|
@chrispad2k just started to work on the readme pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧🚧 Only if you want to try the unstable beta of GraphQL PPX 1.0 🚧🚧
GraphQL PPX adds quite a bit of breaking changes, this fork makes it compatible.
There are also some other changes, as this is the version we use in production
Mainly