Skip to content

Commit

Permalink
Merge pull request vmware-tanzu#8225 from emmanuel-ferdman/main
Browse files Browse the repository at this point in the history
Update the wait-for-additional-items design doc link
  • Loading branch information
blackpiglet authored Sep 18, 2024
2 parents 3f9c2dc + 5d0f09d commit 95f6729
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion design/Implemented/plugin-versioning.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ In cases where the methods signatures remain the same, the adaptation layer will
Examples where an adaptation may be safe:
- A method signature is being changed to add a new parameter but the parameter could be optional (for example, adding a context parameter). The adaptation could call through to the method provided in the previous version but omit the parameter.
- A method signature is being changed to remove a parameter, but it is safe to pass a default value to the previous version. The adaptation could call through to the method provided in the previous version but use a default value for the parameter.
- A new method is being added but does not impact any existing behaviour of Velero (for example, a new method which will allow Velero to [wait for additional items to be ready](https://github.com/vmware-tanzu/velero/blob/main/design/wait-for-additional-items.md)). The adaptation would return a value which allows the existing behaviour to be performed.
- A new method is being added but does not impact any existing behaviour of Velero (for example, a new method which will allow Velero to [wait for additional items to be ready](https://github.com/vmware-tanzu/velero/blob/main/design/Implemented/wait-for-additional-items.md)). The adaptation would return a value which allows the existing behaviour to be performed.
- A method is being deleted as it is no longer used. The adaptation would call through to any methods which are still included but would omit the deleted method in the adaptation.

Examples where an adaptation may not be safe:
Expand Down

0 comments on commit 95f6729

Please sign in to comment.