Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #450 copy types definition into graphql server repo #452

Merged
merged 3 commits into from
Feb 27, 2020
Merged

chore: #450 copy types definition into graphql server repo #452

merged 3 commits into from
Feb 27, 2020

Conversation

trankhacvy
Copy link
Contributor

@trankhacvy trankhacvy commented Feb 27, 2020 •
edited by duong-se
Loading

fixes: #450

willmcvay
willmcvay requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The task was to create a script to do this automatically
  • Should only import the definitions themselves for platform, we don't need the marketplace ones and all the other manifest files

duong-se
duong-se reviewed Feb 27, 2020
View reviewed changes
packages/graphql-server/src/20200131/package.json Outdated
@@ -0,0 +1,23 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove it from this folder

duong-se
duong-se reviewed Feb 27, 2020
View reviewed changes
packages/graphql-server/src/20200131/README.md Outdated
@@ -0,0 +1,9 @@
# Foundations TS Definitions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove this

duong-se
duong-se reviewed Feb 27, 2020
View reviewed changes
packages/graphql-server/src/20200131/tsconfig.json Outdated
@@ -0,0 +1,12 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove this

@trankhacvy
Copy link
Contributor Author

  • The task was to create a script to do this automatically
  • Should only import the definitions themselves for platform, we don't need the marketplace ones and all the other manifest files

@willmcvay For now, I just manually copy these files and create this pull request for other people can resolve these graphql pull requests. I will create the command line later.

@duong-se duong-se changed the title chore: Copy types definition into graphql server repo chore: #450 copy types definition into graphql server repo Feb 27, 2020
@trankhacvy trankhacvy force-pushed the chore/copy-type-definition-into-graphql-server-repo branch from 7e734f0 to ece6c64 Compare February 27, 2020 09:48
willmcvay
willmcvay approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@trankhacvy trankhacvy merged commit 6e26d14 into master Feb 27, 2020
@trankhacvy trankhacvy deleted the chore/copy-type-definition-into-graphql-server-repo branch February 27, 2020 11:13
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@trankhacvy
chore: #450 copy types definition into graphql server repo (#452)
d435601 
* chore: Copy types definition into graphql server repo

* chore: remove un-use files

* chore: rename types folder
@willmcvay willmcvay mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@nphivu414 nphivu414 nphivu414 approved these changes

@willmcvay willmcvay willmcvay approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@duong-se duong-se Awaiting requested review from duong-se

Assignees

@trankhacvy trankhacvy

Labels
graphql-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement platform version to GraphQL service
5 participants
@trankhacvy @willmcvay @nphivu414 @duong-se @vuhuucuong